-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-pseudo] clarify paired cascade (#6386 + #6779 + #6774 + #7837) #6665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delan
changed the title
[css-pseudo] clarify paired cascade (#6386)
[css-pseudo-4] clarify paired cascade (#6386)
Sep 22, 2021
delan
changed the title
[css-pseudo-4] clarify paired cascade (#6386)
[css-pseudo-4] clarify paired cascade (#6386 + #6150)
Oct 5, 2021
delan
changed the title
[css-pseudo-4] clarify paired cascade (#6386 + #6150)
[css-pseudo] clarify paired cascade (#6386 + #6150)
Nov 2, 2021
delan
changed the title
[css-pseudo] clarify paired cascade (#6386 + #6150)
[css-pseudo] clarify paired cascade (closes #6386)
Nov 2, 2021
delan
changed the title
[css-pseudo] clarify paired cascade (closes #6386)
[css-pseudo] clarify paired cascade (closes #6386 + #6779)
Nov 18, 2021
fantasai
reviewed
Nov 30, 2021
delan
changed the title
[css-pseudo] clarify paired cascade (closes #6386 + #6779)
[css-pseudo] clarify paired cascade (#6386 + #6779 + #6774)
Apr 15, 2022
@fantasai, @frivoal, some notable improvements to this patch since your last reviews:
I believe the new proposed text is clearer than ever, and conveys all of the details I wanted to convey (see pr description for the complete list) in far fewer words. Please take a look! |
fantasai
requested changes
Sep 1, 2022
fantasai
reviewed
Oct 4, 2022
delan
changed the title
[css-pseudo] clarify paired cascade (#6386 + #6779 + #6774)
[css-pseudo] clarify paired cascade (#6386 + #6779 + #6774 + #7837)
Oct 6, 2022
fantasai
approved these changes
Oct 6, 2022
Ok, looks good. Please SQUASH and rebase before merging. :) |
Thank you both for all of your feedback! |
This was referenced Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes edits for #6386:
clarifies that UAs are still allowed to tweak highlight colors (@delan’s comment)This patch also makes edits for #6779:
This patch also makes edits for #6774 (@delan’s comment):