[css-syntax-3][css-values-3][css-cascade-4][css-fonts-4] Formalize fetching and resource timing reporting #6715

noamr · 2021-10-05T08:13:57Z

Add a generic method to fetch style resources, and make use of it in
fonts & imports.

[css-syntax-3]: Make sure we have a location when parsing a stylesheet, as the location is necessary for parsing import rules.
[css-values-3]: Add a reusable method to fetch a style-originated
resource.
[css-cascade-4]: Formalize the import algorithm to use the new fetch
method.
[css-fonts-4]: Formalize font loading to use the new fetch method. Removed some of the font loading "guidelines" as they are now baked in to the algorithm.
[css-shapes-2]: Load css-shapes external images/SVG using fetch style resoure

See #562

Fixes #6076

Tests: web-platform-tests/wpt#31344

noamr · 2021-10-05T08:19:07Z

Open-ish issues:

The reusable method has two modes: "cors" and "no-cors". "cors" is used currently only for fonts. When "cors" is used, the referrer is set to the stylesheet's url rather than to the document's origin, and credentials are included only when the request is same-origin. I believe that this should be the general rule for anonymous cors style resources, if there are ever additional ones. But we should look at this carefully, maybe when there is a second use-case for cors style-originated resources.
The PR adds a new ref and uses it, does it need to be in separate PRs to work?
Requires some new tests, especially for the referrer stuff, which currently has different behaviors across browsers.
Initial loading of the stylesheet (from link or CSSOM) is not handled in this PR, only style-originated resources.
Not yet integrated with [css-images] and with SVG for [css-shapes] (any resource that I've missed?).

tabatkins

In addition to the individual comments nits, most of which can be fixed by accepting the provided suggestions, there's some style nits where your additions don't match the surrounding spec and would need to be reformatted at some point by us.

CSSWG style is to give the algo steps their actual numbers when using Markdown numbered lists, and most importantly, we use semantic linebreaks, breaking at sentence/phrase/clause boundaries (usually after commas or before conjunctions) as feels appropriate for meaningful units of text that aren't overly long.

Otherwise looks great, thanks so much for filling in details that I was gradually loading into my head on my own. Would you mind also doing the CSSOM "load a stylesheet" algo? (In this PR or separate, doesn't matter.)

css-cascade-4/Overview.bs

css-syntax-3/Overview.bs

css-values-4/Overview.bs

css-cascade-4/Overview.bs

css-fonts-4/Overview.bs

tabatkins · 2021-10-05T17:14:57Z

Not yet integrated with [css-images] and with SVG for [css-shapes] (any resource that I've missed?).

I think Colors 4, for @color-profile, is the only other place we load resources currently.

noamr · 2021-10-06T09:49:46Z

In addition to the individual comments nits, most of which can be fixed by accepting the provided suggestions, there's some style nits where your additions don't match the surrounding spec and would need to be reformatted at some point by us.

CSSWG style is to give the algo steps their actual numbers when using Markdown numbered lists, and most importantly, we use semantic linebreaks, breaking at sentence/phrase/clause boundaries (usually after commas or before conjunctions) as feels appropriate for meaningful units of text that aren't overly long.

OK I fixed that as well. Let me know if anything else is missing.

Would you mind also doing the CSSOM "load a stylesheet" algo? (In this PR or separate, doesn't matter.)

I will try to find the time to look at this separately, and it probably wouldn't use the "fetch a style resource" algorithm as stylesheets loaded like that are not exactly style resources. Seems like that algorithm is only used internally in CSSOM, for things like XML stylesheets and link headers. I wouldn't use it for HTML, as it would require too much information about link element specifics.

svgeesus · 2021-10-06T14:53:49Z

@noamr could you please link your W3C account to your GitHub account? Our IPR bot doesn't know who you are, otherwise. Thanks!

svgeesus · 2021-10-06T14:56:56Z

I think Colors 4, for @color-profile, is the only other place we load resources currently.

Yes, 10.3. Specifying a color profile: the @color-profile at-rule which should point to the new, centrally-defined "how CSS does fetch" stuff.

Thanks for doing all this, @noamr much appreciated.

css-fonts-4/Overview.bs

noamr · 2021-10-06T16:54:56Z

@noamr could you please link your W3C account to your GitHub account? Our IPR bot doesn't know who you are, otherwise. Thanks!

I just logged in to my w3c account (noamr) and it's connected. I think I'm not in the repository's group though, there was some similar issue when I contributed to css-shapes a few months ago.

noamr · 2021-10-11T07:03:31Z

@noamr could you please link your W3C account to your GitHub account? Our IPR bot doesn't know who you are, otherwise. Thanks!

I just logged in to my w3c account (noamr) and it's connected. I think I'm not in the repository's group though, there was some similar issue when I contributed to css-shapes a few months ago.

@svgeesus anything we can do about this? Not sure what's missing IPR-wise

Add a generic method to fetch style resources, and make use of it in fonts & imports. [css-syntax-3]: Make sure we have a location when parsing a stylesheet. [css-values-3]: Add a reusable method to fetch a style-originated resource. [css-cascade-4]: Formalize the import algorithm to use the new fetch method. [css=fonts-4]: Formalize font loading to use the new fetch method.

Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>

noamr · 2021-10-11T08:00:10Z

Added support for CSS shapes, still missing css-images and color profiles.

svgeesus · 2021-10-11T16:54:00Z

@svgeesus anything we can do about this? Not sure what's missing IPR-wise

Yes, I just sent you an email with a non-participant commitment. Actually I will send two, one now for the spec with the largest change and then (once you are done patching all our fetch holes) another listing all the other specs that were changed, that says "and the same for these".

noamr · 2021-10-12T04:56:17Z

@svgeesus anything we can do about this? Not sure what's missing IPR-wise

Yes, I just sent you an email with a non-participant commitment. Actually I will send two, one now for the spec with the largest change and then (once you are done patching all our fetch holes) another listing all the other specs that were changed, that says "and the same for these".

So, you suggest that I finish the remaining FETCH holes as part of this PR and do an IPR thing for all these specs together?
Only css-color and css-images are now missing (CSSOM stylesheet loading will be separate).

svgeesus · 2021-10-12T12:03:57Z

Yes, that would be perfect.

annevk · 2021-10-12T12:13:30Z

css-values-4/Overview.bs

+			is |environmentSettings|'s [=environment settings object/origin=],
+			[=request/credentials mode=] is "same-origin", [=request/use-url-credentials flag=] is
+			set, and whose [=request/header list=] is a [=/header list=] containing a [=header=]
+			with its [=header/name=] set to "referrer" and its [=header/value=] set to |referrer|.


This is somewhat wrong. You want to set the referrer field on the request. That will set the Referer (note, one r less) header. But good that it sets it explicitly though as CSS cannot take it from the global.

Right, fixed.

noamr · 2021-10-12T12:28:36Z

Yes, that would be perfect.

That's all done now. No additional specs planned for this PR :)

svgeesus · 2021-10-12T12:40:56Z

@tabatkins have your requested changes been made?

noamr · 2021-10-12T12:42:43Z

@tabatkins have your requested changes been made?

I think I made lots of changes since. It would be good to re-review.
Also, I put color-profile fetches as no-cors, which is an assumption as it was not specified so far.

domenic · 2021-10-12T21:17:31Z

Also, I put color-profile fetches as no-cors, which is an assumption as it was not specified so far.

As mentioned in whatwg/fetch#1324, it'd be best if they used CORS, like all other modern web platform features (w3ctag/design-principles#171 (comment))

noamr · 2021-10-18T15:38:48Z

@tabatkins have your requested changes been made?

Reminder to take another look when possible, @tabatkins :)

This reverts commit e610888.

noamr · 2021-11-03T16:46:21Z

Ping?

Timed out, better to merge now and fix any nits later

fantasai · 2021-11-09T02:13:26Z

@svgeesus Can you rebase PRs before you merge, please? Unless it's a complicated conflicty thing that really requires a merge commit, history is a lot cleaner with a rebase. (There's a drop-down button next to the Merge button in GH that let's you choose whether to rebase or not. I'm pretty sure I've mentioned this before...)

fantasai · 2021-11-09T02:17:03Z

@noamr If it's not too much trouble, would you mind adding yourself to the acknowledgements section of at least some of these specs? Your call on which ones, and I'm happy to merge that PR. But I think you deserve some credit for sorting this out. :)

noamr · 2021-11-09T06:47:45Z

@svgeesus Can you rebase PRs before you merge, please? Unless it's a complicated conflicty thing that really requires a merge commit, history is a lot cleaner with a rebase. (There's a drop-down button next to the Merge button in GH that let's you choose whether to rebase or not. I'm pretty sure I've mentioned this before...)

I think the Github settings allow to change the default to "Squash and merge", wouldn't that be preferable?

css-meeting-bot · 2021-11-10T17:07:02Z

The CSS Working Group just discussed URLs vs Fetch.

The full IRC log of that discussion

<fantasai> Topic: URLs vs Fetch
<fantasai> github: https://github.com//pull/6715/files
<dbaron> github: github: https://github.com//pull/6715
<drott> fantasai: areas where we need to better integarte with the fetch spec
<dbaron> github: https://github.com//pull/6715
<drott> fantasai: chris recently merged PR contributed by contributor
<drott> fantasai: we need those to be reviewed - and ask to publish these changes
<chris> rrsagent, here
<RRSAgent> See https://www.w3.org/2021/11/10-css-irc#T17-04-45
<drott> ikilpatrick: did these get reviewed by anna or nicole?
<drott> tab: I did review it
<drott> tab: anna and domenic coordinating on reviewing...
<chris> Yeah I reviewed it too
<fantasai> s/anna/anne/
<drott> fantasai: if it sounds like it's been reviewed, then I'd suggest to accept the changes
<dbaron> s/nicole/Dominic Denicola/
<drott> > s/nicole/Dominic Denicola/ - sorry about, that, of course
<fantasai> i/github: github:/scribenick: drott/
<fantasai> scribenick: fantasai

noamr mentioned this pull request Oct 5, 2021

Be a bit more explicit about which subresources are to be ignored from stylesheets w3c/resource-timing#200

Closed

tabatkins previously requested changes Oct 5, 2021

View reviewed changes

This was referenced Oct 6, 2021

[css-fonts-4] “Font fetching requirements” doesn’t fully specify necessary requirements #6076

Closed

[css-masking-1] Fetch doesn't define "potentially CORS-enabled fetch" w3c/fxtf-drafts#358

Open

svgeesus reviewed Oct 6, 2021

View reviewed changes

css-fonts-4/Overview.bs Show resolved Hide resolved

css-fonts-4/Overview.bs Outdated Show resolved Hide resolved

noamr mentioned this pull request Oct 7, 2021

Missing destination types for some style initiated resources whatwg/fetch#1324

Open

noamr and others added 9 commits October 11, 2021 10:09

Use more precise terms for same-origin

6865584

Update css-fonts-4/Overview.bs

e47f6fe

Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>

Update css-cascade-4/Overview.bs

05e285e

Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>

Update css-values-4/Overview.bs

99b8996

Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>

Apply suggestions from code review

ab66419

Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>

Nits

34002f2

Numbering

ffc8bf7

Tighten fetch integration, add shape support

69379fb

noamr force-pushed the resource-load branch from 8f0a10e to 69379fb Compare October 11, 2021 07:58

annevk reviewed Oct 12, 2021

View reviewed changes

noamr added 2 commits October 12, 2021 15:17

Shapes, images, colors

6dc96e0

Correct referrer

e053f32

svgeesus requested a review from tabatkins October 12, 2021 12:45

Switch colorprofile fetching to cors

cdbbf63

noamr mentioned this pull request Oct 21, 2021

Add tests for how styles fetch resources from the network web-platform-tests/wpt#31344

Merged

Remove referer thing for now

e610888

noamr mentioned this pull request Oct 28, 2021

[css-fonts] Clarify: use of referrers in font fetching and relationship with preloads #6775

Closed

Revert "Remove referer thing for now"

45e648d

This reverts commit e610888.

svgeesus merged commit 53ead22 into w3c:main Nov 3, 2021

fantasai added a commit that referenced this pull request Nov 9, 2021

[css-values-4] Fetch integration fixes: typos, acks, changes list. #6715

50e9085

noamr mentioned this pull request Nov 9, 2021

[css-cascade-4] Add myself to contributor list #6804

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[css-syntax-3][css-values-3][css-cascade-4][css-fonts-4] Formalize fetching and resource timing reporting #6715

[css-syntax-3][css-values-3][css-cascade-4][css-fonts-4] Formalize fetching and resource timing reporting #6715

noamr commented Oct 5, 2021 •

edited

Loading

noamr commented Oct 5, 2021 •

edited

Loading

tabatkins left a comment •

edited

Loading

tabatkins commented Oct 5, 2021

noamr commented Oct 6, 2021

svgeesus commented Oct 6, 2021

svgeesus commented Oct 6, 2021

noamr commented Oct 6, 2021

noamr commented Oct 11, 2021

noamr commented Oct 11, 2021

svgeesus commented Oct 11, 2021

noamr commented Oct 12, 2021

svgeesus commented Oct 12, 2021

annevk Oct 12, 2021

noamr Oct 12, 2021

noamr commented Oct 12, 2021

svgeesus commented Oct 12, 2021

noamr commented Oct 12, 2021 •

edited

Loading

domenic commented Oct 12, 2021

noamr commented Oct 18, 2021

noamr commented Nov 3, 2021

fantasai commented Nov 9, 2021 •

edited

Loading

fantasai commented Nov 9, 2021

noamr commented Nov 9, 2021

css-meeting-bot commented Nov 10, 2021

[css-syntax-3][css-values-3][css-cascade-4][css-fonts-4] Formalize fetching and resource timing reporting #6715

[css-syntax-3][css-values-3][css-cascade-4][css-fonts-4] Formalize fetching and resource timing reporting #6715

Conversation

noamr commented Oct 5, 2021 • edited Loading

noamr commented Oct 5, 2021 • edited Loading

tabatkins left a comment • edited Loading

Choose a reason for hiding this comment

tabatkins commented Oct 5, 2021

noamr commented Oct 6, 2021

svgeesus commented Oct 6, 2021

svgeesus commented Oct 6, 2021

noamr commented Oct 6, 2021

noamr commented Oct 11, 2021

noamr commented Oct 11, 2021

svgeesus commented Oct 11, 2021

noamr commented Oct 12, 2021

svgeesus commented Oct 12, 2021

annevk Oct 12, 2021

Choose a reason for hiding this comment

noamr Oct 12, 2021

Choose a reason for hiding this comment

noamr commented Oct 12, 2021

svgeesus commented Oct 12, 2021

noamr commented Oct 12, 2021 • edited Loading

domenic commented Oct 12, 2021

noamr commented Oct 18, 2021

noamr commented Nov 3, 2021

fantasai commented Nov 9, 2021 • edited Loading

fantasai commented Nov 9, 2021

noamr commented Nov 9, 2021

css-meeting-bot commented Nov 10, 2021

noamr commented Oct 5, 2021 •

edited

Loading

noamr commented Oct 5, 2021 •

edited

Loading

tabatkins left a comment •

edited

Loading

noamr commented Oct 12, 2021 •

edited

Loading

fantasai commented Nov 9, 2021 •

edited

Loading