[css-view-transitions-1][css-view-transitions-2] Initial draft for cross-document view transitions #9022

noamr · 2023-07-02T17:37:22Z

This lays the foundations for cross-document view transitions.
Specifically:

The opt-in
The reveal event

See https://github.com/WICG/view-transitions/blob/main/cross-doc-explainer.md

css-view-transitions-1/Overview.bs

css-view-transitions-2/Overview.bs

khushalsagar · 2023-07-05T19:19:07Z

css-view-transitions-2/Overview.bs

+	To <dfn>reveal {{Document}}</dfn> |document|:
+		1. Assert: |document|'s [=page showing=] is false.
+
+		1. If |document| is [=render-blocked=] then return.


Why this check? We call this function when render blocking is finished (or timed out). So assert that we're not render-blocked?

We also call it on reactivation, which could happen when the document is still render blocked (e.g. you activate a prerendered page really quickly before it's unblocked). To clarify, I moved this line into the reactivation bit.

css-view-transitions-2/Overview.bs

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

css-view-transitions-2/Overview.bs

khushalsagar · 2023-07-13T16:26:08Z

css-view-transitions-2/Overview.bs

+
+		1. [=reveal document|reveal=] |document|.
+
+		Reword the text in the [=render-blocked=] definition, to call [=reveal document=] |document| if the [=implementation-defined=] timeout value has been exceeded.


This should be an issue?

khushalsagar · 2023-07-13T17:07:26Z

css-view-transitions-2/Overview.bs

+
+			1. |outboundTransition|'s [=ViewTransition/phase=] is not "`pending-capture`", then call |onReady| and return.
+
+			1. If |oldDocument| does not [=opt in to cross-document view transitions|opts in to cross-document view transitions=],


Why do we need a check here? Didn't we already do it before initiating the capture?

In case the developer changes the opt-in in a rAF callback. It's questionable though, I don't mind removing this for now, maybe replace with an inline issue?

css-view-transitions-2/Overview.bs

khushalsagar · 2023-07-13T17:18:29Z

css-view-transitions-2/Overview.bs

+	<div algorithm>
+		To get the <dfn>inbound cross-document view-transition</dfn> for a {{Document}} |document|:
+
+		1. If |document| does not [=opt in to cross-document view transitions=], then return null.


I don't think we should have a check for this here. If there is an "active view transition" whose "is cross document" is true then that's always returned. The places where the opt in is checked should be explicit and we should clear the "active view transition" at those places if needed.

khushalsagar · 2023-07-13T17:20:08Z

css-view-transitions-2/Overview.bs

+
+		1. Let |transition| be |document|'s [=active view transition=].
+
+		1. If |transition| is null or |transition|'s [=ViewTransition/is cross-document=] is false,


nit: Do you mind using "is inbound cross-document"? Just to make it explicit that the bit is only set for the VT object on the new Document.

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

css-view-transitions-1/Overview.bs

khushalsagar · 2023-07-13T18:28:50Z

css-view-transitions-1/Overview.bs

@@ -1565,6 +1572,8 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

 		1. [=Assert=]: |transition|'s [=ViewTransition/phase=] is not "`done`".

+		1. If |transition|'s [=ViewTransition/phase=] is "`pending-capture`" and |transition|'s [=ViewTransition/process old state captured=] is not null, then call [=ViewTransition/process old state captured=] and return.


Shouldn't the phase value be updated before calling "process old state captured"? Otherwise that algorithm will incorrectly assume that the capture was successful.

Doing this as the last step is a good idea.

css-view-transitions-1/Overview.bs

khushalsagar · 2023-07-13T18:40:34Z

css-view-transitions-2/Overview.bs


 		1. Let |transition| be the result of getting the [=inbound cross-document view-transition=] for |document|.

+		1. If |document| does not [=opt in to cross-document view transitions=], then [=skip the view transition|skip=] |transition| and set |transition| to null.


nit: Do we need a null check for transition here? Also, I think you want say set document's active view transition to null. Mapping this to code, transition is now a local variable in this algorithm so resetting it won't reset the member variable on Document.

skip transition already sets the active view transition to null.
Fixed the nit.

css-view-transitions-2/Overview.bs

noamr marked this pull request as draft July 2, 2023 17:37

noamr marked this pull request as ready for review July 4, 2023 11:44

noamr closed this Jul 4, 2023

noamr reopened this Jul 4, 2023

khushalsagar reviewed Jul 5, 2023

View reviewed changes

noamr and others added 8 commits July 13, 2023 08:53

WIP css-view-transitions-2

75135b4

Add examples

8a3a87f

Update css-view-transitions-2/Overview.bs

a3508dd

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

Update css-view-transitions-2/Overview.bs

4aefea2

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

Update css-view-transitions-2/Overview.bs

fdc79c0

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

Many PR changes

2c0b271

Add Vlad

09207d5

Make it explicit when we capture the old state

e0989f4

noamr force-pushed the css-view-transitions-2 branch from 257239a to e0989f4 Compare July 13, 2023 09:06

noamr added 3 commits July 13, 2023 12:18

Fix biblio ref

d410405

Move HTML monkey patch

f99cb71

Clarify HTML entry point in old document

fd1fd78

khushalsagar reviewed Jul 13, 2023

View reviewed changes

noamr and others added 7 commits July 13, 2023 20:24

Bring back render-blocked check

79d6e94

Update css-view-transitions-1/Overview.bs

ff9d928

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

Update css-view-transitions-1/Overview.bs

46640f7

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

Update css-view-transitions-2/Overview.bs

2fd4da4

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

Update css-view-transitions-2/Overview.bs

da18f1e

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

Fix many PR comments

a917ec4

Call ready callback on skip

472b089

noamr changed the title ~~WIP css-view-transitions-2~~ [css-view-transitions-1][css-view-transitions-2] Initial draft for cross-document view transitions Jul 13, 2023

khushalsagar approved these changes Jul 13, 2023

View reviewed changes

noamr and others added 3 commits July 13, 2023 21:59

Few nits

f78c3e2

Fix calling the process old state captured callback

cc4fe52

Unintended edit

6ae4635

Clear ViewTransition on old doc for BFCache

bf17e69

khushalsagar merged commit e695902 into w3c:main Jul 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[css-view-transitions-1][css-view-transitions-2] Initial draft for cross-document view transitions #9022

[css-view-transitions-1][css-view-transitions-2] Initial draft for cross-document view transitions #9022

noamr commented Jul 2, 2023 •

edited

Loading

khushalsagar Jul 5, 2023

noamr Jul 12, 2023

khushalsagar Jul 13, 2023

noamr Jul 13, 2023

khushalsagar Jul 13, 2023

noamr Jul 13, 2023

khushalsagar Jul 13, 2023

noamr Jul 13, 2023

khushalsagar Jul 13, 2023

noamr Jul 13, 2023

khushalsagar Jul 13, 2023

noamr Jul 13, 2023

khushalsagar Jul 13, 2023

noamr Jul 13, 2023


		1. [=reveal document\|reveal=] \|document\|.

		Reword the text in the [=render-blocked=] definition, to call [=reveal document=] \|document\| if the [=implementation-defined=] timeout value has been exceeded.


		1. \|outboundTransition\|'s [=ViewTransition/phase=] is not "`pending-capture`", then call \|onReady\| and return.

		1. If \|oldDocument\| does not [=opt in to cross-document view transitions\|opts in to cross-document view transitions=],


		1. Let \|transition\| be \|document\|'s [=active view transition=].

		1. If \|transition\| is null or \|transition\|'s [=ViewTransition/is cross-document=] is false,

		@@ -1565,6 +1572,8 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

		1. [=Assert=]: \|transition\|'s [=ViewTransition/phase=] is not "`done`".

		1. If \|transition\|'s [=ViewTransition/phase=] is "`pending-capture`" and \|transition\|'s [=ViewTransition/process old state captured=] is not null, then call [=ViewTransition/process old state captured=] and return.


		1. Let \|transition\| be the result of getting the [=inbound cross-document view-transition=] for \|document\|.

		1. If \|document\| does not [=opt in to cross-document view transitions=], then [=skip the view transition\|skip=] \|transition\| and set \|transition\| to null.

[css-view-transitions-1][css-view-transitions-2] Initial draft for cross-document view transitions #9022

[css-view-transitions-1][css-view-transitions-2] Initial draft for cross-document view transitions #9022

Conversation

noamr commented Jul 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noamr commented Jul 2, 2023 •

edited

Loading