Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change client to player #206

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

nigelmegitt
Copy link
Contributor

@nigelmegitt nigelmegitt commented Jan 17, 2024

Change "client" to "player" at the end of §2.1. Closes #202.


Preview | Diff

Copy link
Contributor

@cconcolato cconcolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Section 2.1.2 contains similar text that says "in the client player". After reading the introduction again, I feel that the last paragraph before 2.1.1 could be removed. It was an initial justification of why AD and Dubs are in the same spec but it does not feel necessary or at least could be simplified and used to introduce the next subsections.

For consistency, to address @cconcolato review comment.
@nigelmegitt
Copy link
Contributor Author

After reading the introduction again, I feel that the last paragraph before 2.1.1 could be removed. It was an initial justification of why AD and Dubs are in the same spec but it does not feel necessary or at least could be simplified and used to introduce the next subsections.

I'm not sure about that @cconcolato - happy to discuss. Will merge this now and we can make that change separately. Have raised it as #212.

@nigelmegitt nigelmegitt merged commit 7787d44 into main Feb 8, 2024
2 checks passed
@nigelmegitt nigelmegitt deleted the issue-0202-change-client-to-player branch February 8, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

§2.1 Clarify that mixing "in the client" means "in the player"
2 participants