Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proof #293

Closed
rhiaro opened this issue May 26, 2020 · 3 comments
Closed

Remove proof #293

rhiaro opened this issue May 26, 2020 · 3 comments
Assignees
Labels
pr exists There is an open PR to address this issue

Comments

@rhiaro
Copy link
Member

rhiaro commented May 26, 2020

proof should not be in DID Core as it is a way to protect content not used by all DID methods. Propose removing it altogether, understanding that it will still be available for those that want to use it via the DID Spec Registries.

@peacekeeper
Copy link
Contributor

This has been proposed before in #26, but I think our understanding of it has evolved since then.

It has been suggested that proofs are not data about the subject, but rather 1) metadata about the DID document, and/or 2) metadata about resolution (see #65 (comment)). This would support that proof should be removed from the DID document and possibly from DID Core altogether.

@kdenhartog
Copy link
Member

It has been suggested that proofs are not data about the subject, but rather 1) metadata about the DID document, and/or 2) metadata about resolution (see #65 (comment)). This would support that proof should be removed from the DID document and possibly from DID Core altogether.

+1 to the sentiment expressed here

@kdenhartog kdenhartog added the editorial Editors should update the spec then close label May 27, 2020
@rhiaro rhiaro removed the editorial Editors should update the spec then close label May 31, 2020
@rhiaro rhiaro added the pr exists There is an open PR to address this issue label May 31, 2020
@marceljay
Copy link

I think it needs to be discussed what the DID-Core spec should address, as it describes important concepts that go beyond the key components of DID documents. It is stated in 7.9 Proof that such proofs are optional, since these proofs can be implicit (e.g. did:sov) and thus considered metadata.

I would suggest a revison of the whole chapter 7, which has some confusing parts, for example regarding verification relationships.
As a suggestion, the chapter could be split into a first section stating the required properties of a DID doc, and a second one that explains parts of the DID document that are optional.

My suggestions in short:

  • Describe implicit proofs in 7.9 and that proofs can be considered metadata
  • Revise chapter 7 and make it more comprehensive and complete (and give it a less ambiguous title than "Core Properties")
  • Consider migrating the DID document part to its own spec that is filled with detailed explanations and more examples

@msporny msporny closed this as completed in e3dcf83 Jun 8, 2020
bcessa added a commit to aidtechnology/did-method that referenced this issue Aug 10, 2020
Several adjustments and improvements.
- Update dependencies and cyrpto libraries.
- New protobuf definitions.
- To support non-standard output returned by different methods, the data
  is not processed in anyway and passed down to standard output.

A breaking change introduced was removing the 'proof' element from the
core DID document as per the specification. The proof is stil being
generated and verified for all operations and returned when resolving
an identifier.

For more information:
w3c/did#293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr exists There is an open PR to address this issue
Projects
None yet
Development

No branches or pull requests

4 participants