Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise section on dataset series as discussed in issue 1272 #1313

Merged

Conversation

andrea-perego
Copy link
Contributor

@andrea-perego andrea-perego commented Mar 5, 2021

Summary of changes:

  • Remove subsetting as a typical example of dataset series
  • Revise section on property values inheritance to include properties describing dataset series themselves - as dct:accrualPeriodicity
  • Move to separate section the description of how dataset series are specified in existing DCAT implementations

Preview: https://raw.githack.com/w3c/dxwg/dcat-dataseries-issue1272-rev/dcat/index.html#dataset-series

Diff: https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fraw.githack.com%2Fw3c%2Fdxwg%2Fdcat-dataseries-issue1272%2Fdcat%2Findex.html&doc2=https%3A%2F%2Fraw.githack.com%2Fw3c%2Fdxwg%2Fdcat-dataseries-issue1272-rev%2Fdcat%2Findex.html#dataset-series

dcat/index.html Outdated Show resolved Hide resolved
@riccardoAlbertoni
Copy link
Contributor

Thanks a lot, Andrea, for summarizing the discussion scattered in different issues in this PR. I think this is quite an improvement, I just add the reference to the discussion on hasPart. I support the idea of merging this to dcat-dataseries-issue1272 after committing my suggestion.

andrea-perego and others added 2 commits March 8, 2021 13:19
Co-authored-by: Riccardo Albertoni <albertoni@ge.imati.cnr.it>
@andrea-perego
Copy link
Contributor Author

Thanks a lot, Andrea, for summarizing the discussion scattered in different issues in this PR. I think this is quite an improvement, I just add the reference to the discussion on hasPart. I support the idea of merging this to dcat-dataseries-issue1272 after committing my suggestion.

Thanks, @riccardoAlbertoni . I applied your revision via commit 8b907eb , and removed the duplicate ref to #1307 via commit 07df66e

If you are happy with this, we can merge this PR.

@andrea-perego andrea-perego marked this pull request as ready for review March 8, 2021 12:24
@riccardoAlbertoni riccardoAlbertoni merged commit 203442e into dcat-dataseries-issue1272 Mar 8, 2021
@riccardoAlbertoni
Copy link
Contributor

I am happy thanks. So I have merged.

@riccardoAlbertoni riccardoAlbertoni deleted the dcat-dataseries-issue1272-rev branch March 8, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants