Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update class diagram according to #1470 #1472

Merged
merged 13 commits into from
Mar 15, 2022
Merged

Conversation

riccardoAlbertoni
Copy link
Contributor

@riccardoAlbertoni riccardoAlbertoni commented Mar 8, 2022

This PR updates the class diagram according to the changed made by #1470

Preview: https://raw.githubusercontent.com/w3c/dxwg/dcat-updateOfDiagram/dcat/images/dcat-all-attributes.svg

@riccardoAlbertoni riccardoAlbertoni added this to the DCAT3 4PWD milestone Mar 8, 2022
@riccardoAlbertoni riccardoAlbertoni changed the title updated class diagram according to #1470 update class diagram according to #1470 Mar 8, 2022
@andrea-perego andrea-perego changed the title update class diagram according to #1470 Update class diagram according to #1470 Mar 8, 2022
@andrea-perego
Copy link
Contributor

Thanks, @riccardoAlbertoni .

I wonder whether we should take this opportunity to do some housekeeping of the image files. We have them in two different subfolders, namely, images and UML, and I'm not sure they are the same versions. This is confusing.

I think it would be better to keep all of them under the images subfolder and delete the UML one.

WDYT?

@andreasgeissner
Copy link

As you folks are working on the image already, may I just jump in and point out a typo? The connection dcat:DataService to dcat:Dataset reads dcat:serversDataset instead of dcat:servesDataset

@riccardoAlbertoni
Copy link
Contributor Author

@andrea-perego
Copy link
Contributor

Thanks, @riccardoAlbertoni .

I think we should also remove the cardinality restrictions:

  • The only cardinality restriction specified in the RDF concerns property dcat:record - to be decided whether to keep it or not
  • The cardinality 1..* of dcat:resource (previously on dcterms:hasPart) is controversial (see discussion in https://www.w3.org/2022/02/22-dxwgdcat-minutes#t03), and should probably be revised into 0..*
  • Cardinalities as 0..* are the default ones, so they needn't be specified

@riccardoAlbertoni
Copy link
Contributor Author

I think we should also remove the cardinality restrictions:

  • The only cardinality restriction specified in the RDF concerns property dcat:record - to be decided whether to keep it or not

I would keep this.

I am ok with changing this.

  • Cardinalities as 0..* are the default ones, so they needn't be specified

I am afraid without cardinalities some people might read 1 as default instead 0..*
I think that the note below the figure explains quite well that cardinalities are not normative, and they are placed to provide usual expectations.

Let's discuss this in tonight's call.
What is the harm that you see in keeping them?
Anyway, If we cancel the cardinalities we need to change the note as well.

@andrea-perego
Copy link
Contributor

@riccardoAlbertoni said:

  • Cardinalities as 0..* are the default ones, so they needn't be specified

I am afraid without cardinalities some people might read 1 as default instead 0..*

Not sure about that. If no cardinality is specified, there are no cardinality restrictions. But we can clarify this in the note.

I think that the note below the figure explains quite well that cardinalities are not normative, and they are placed to provide usual expectations.

Yes, but if the cardinality is 0..* there is no need to make it explicit for the reason above.

Let's discuss this in tonight's call. [...]

Agreed.

@agbeltran
Copy link
Member

@riccardoAlbertoni the dcat:Relationship part of the diagram has overlapping parts at the moment:

Screenshot 2022-03-08 at 21 48 22

@dr-shorthair
Copy link
Contributor

I am afraid without cardinalities some people might read 1 as default instead 0..*

Yes, that was the original motivation. In standard UML the default is 1..1

@riccardoAlbertoni
Copy link
Contributor Author

@riccardoAlbertoni the dcat:Relationship part of the diagram has overlapping parts at the moment:

Screenshot 2022-03-08 at 21 48 22

@agbeltran we have solved this and other glitches via e6788ef

@riccardoAlbertoni
Copy link
Contributor Author

I am afraid without cardinalities some people might read 1 as default instead 0..*

Yes, that was the original motivation. In standard UML the default is 1..1

During the last DCAT meeting, we voted resolution 03 for the removal of all the cardinalities except those originally present in the RDF. The rationale is to reinforce the message that we do not normatively constraint them.

According to the meeting discussion, providing general expectations might be misleading in some cases, and by the way, cardinalities are not present for all the relations, which is another source of confusion.

e0f25df implements the voted resolution, dropping all the cardinalities and restating in the caption of the diagram that "Except where specifically indicated, DCAT does not provide cardinality constraints."

@agbeltran agbeltran merged commit 8e5d1e1 into gh-pages Mar 15, 2022
@agbeltran agbeltran deleted the dcat-updateOfDiagram branch March 15, 2022 11:56
@andrea-perego
Copy link
Contributor

The changelog needs to be updated accordingly (#1471)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants