-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update class diagram according to #1470 #1472
Conversation
Thanks, @riccardoAlbertoni . I wonder whether we should take this opportunity to do some housekeeping of the image files. We have them in two different subfolders, namely, I think it would be better to keep all of them under the WDYT? |
As you folks are working on the image already, may I just jump in and point out a typo? The connection dcat:DataService to dcat:Dataset reads dcat:serversDataset instead of dcat:servesDataset |
I have implemented the suggestions made by @andrea-perego:
and I have fixed the typo serversDataset -> servesDataset thanks @andreasgeissner |
Thanks, @riccardoAlbertoni . I think we should also remove the cardinality restrictions:
|
I would keep this.
I am ok with changing this.
I am afraid without cardinalities some people might read 1 as default instead 0..* Let's discuss this in tonight's call. |
@riccardoAlbertoni said:
Not sure about that. If no cardinality is specified, there are no cardinality restrictions. But we can clarify this in the note.
Yes, but if the cardinality is 0..* there is no need to make it explicit for the reason above.
Agreed. |
@riccardoAlbertoni the |
Yes, that was the original motivation. In standard UML the default is |
@agbeltran we have solved this and other glitches via e6788ef |
…0220308 Delete the cardinality as indicated in last meeting resolution
During the last DCAT meeting, we voted resolution 03 for the removal of all the cardinalities except those originally present in the RDF. The rationale is to reinforce the message that we do not normatively constraint them. According to the meeting discussion, providing general expectations might be misleading in some cases, and by the way, cardinalities are not present for all the relations, which is another source of confusion. e0f25df implements the voted resolution, dropping all the cardinalities and restating in the caption of the diagram that "Except where specifically indicated, DCAT does not provide cardinality constraints." |
The changelog needs to be updated accordingly (#1471) |
This PR updates the class diagram according to the changed made by #1470
It relates to Changes to Class Diagram (figure 1). #1320
Preview: https://raw.githubusercontent.com/w3c/dxwg/dcat-updateOfDiagram/dcat/images/dcat-all-attributes.svg