Clean up manifest fallbacks section and add an extra caution #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iherman
requested changes
Apr 3, 2022
remove caution note for manifest fallbacks and change caution on content fallbacks to a note and reword
iherman
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1464, this PR separates the requirements for spine fallbacks from the requirements for content fallbacks.
I've also taken the technical details about the
fallbackattribute and merged them back into theitemelement definition, as this was the most bothersome part to me in moving this section up.I've also added another layer of caution to the content fallbacks section that the mechanism was meant for
imgwhich now has other fallback mechanisms.Preview | Diff