Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check that non-linear content is reachable #1451

Closed
rdeltour opened this issue Dec 8, 2022 · 1 comment · Fixed by #1464
Closed

check that non-linear content is reachable #1451

rdeltour opened this issue Dec 8, 2022 · 1 comment · Fixed by #1464
Assignees
@rdeltour
Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: has PR The issue is being processed in a pull request type: false-negative This issue is about invalid content being incorrectly accepted
Milestone
v5.0.0-rc

Comments

@rdeltour
Copy link
Member

rdeltour commented Dec 8, 2022 •
edited
Loading

The spec says:

EPUB creators MUST provide a means of accessing all non-linear content (e.g., hyperlinks in the content or from the EPUB navigation document).

That does not seem to be checked by EPUBCheck.
@rdeltour rdeltour added status: accepted Ready to be further processed type: false-negative This issue is about invalid content being incorrectly accepted spec: EPUB 3.3 Impacting the support of EPUB 3.3 labels Dec 8, 2022
@rdeltour rdeltour self-assigned this Dec 8, 2022
@rdeltour rdeltour added this to the v5.0.0-rc milestone Dec 8, 2022
rdeltour added a commit that referenced this issue Dec 15, 2022
@rdeltour
feat: check that non-linear content is reachable
5dd9553 
EPUB 3.3 says:
> EPUB creators MUST provide a means of accessing all non-linear content
> (e.g., hyperlinks in the content or from the EPUB navigation document).

This commit adds a check for the above statement.
- new error `OPF-096` is reported when no hyperlink was found to
  non-linear content in an EPUB with no script
- new usage `OPF-096b` is reported when no hyperlink was found to
  non-linear content in a scripted EPUB (a link may be added via
  scripting, so we cannot report this as an error)

Fix #1451
@rdeltour rdeltour mentioned this issue Dec 15, 2022
Merged
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request and removed status: accepted Ready to be further processed labels Dec 15, 2022
@mattgarrish
Copy link
Member

I'm kind of worried about this one, but I guess we can wait and see who complains. The cover page is often identified as non-linear, and unless it's included in the landmarks it's going to trigger errors for people as it's not something you can easily find another location to add a link to it.

@rdeltour rdeltour mentioned this issue Mar 6, 2023
Open
@mattgarrish mattgarrish mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
spec: EPUB 3.3 Impacting the support of EPUB 3.3 status: has PR The issue is being processed in a pull request type: false-negative This issue is about invalid content being incorrectly accepted
Projects
None yet
Milestone
v5.0.0-rc
Development

Successfully merging a pull request may close this issue.

feat: check that non-linear content is reachable w3c/epubcheck
2 participants
@rdeltour @mattgarrish