Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop SecureContext extended attrs from interfaces #194

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Drop SecureContext extended attrs from interfaces #194

merged 1 commit into from
Feb 22, 2024

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Feb 15, 2024 •
edited by pr-preview bot
Loading

@marcoscaceres marcoscaceres mentioned this pull request Feb 16, 2024
Merged
@marcoscaceres
Copy link
Member Author

Send PR to WebKit to remove the warning.

@msub2 msub2 mentioned this pull request Feb 16, 2024
Open
4 tasks
@msub2
Copy link

msub2 commented Feb 16, 2024

There is a separate WPT test for secure context also https://wpt.fyi/results/gamepad/gamepad-secure-context.html?label=experimental&label=master&aligned

webkit-commit-queue pushed a commit to marcoscaceres/WebKit that referenced this pull request Feb 19, 2024
@marcoscaceres
Drop insecure contexts warning from getGamepads()
5300e77 
https://bugs.webkit.org/show_bug.cgi?id=269514
rdar://123039555

Reviewed by Chris Dumez.

Removed console warning about restricting to secure contexts.
Chrome is also removed the warning.
Firefox is removing the restriction.
w3c/gamepad#145 (comment)

Related pull request on the W3C gamepad spec:
w3c/gamepad#194

* LayoutTests/http/tests/misc/gamepads-insecure-expected.txt:
* LayoutTests/http/tests/misc/gamepads-insecure.html:
* Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:

Canonical link: https://commits.webkit.org/274962@main
@marcoscaceres
Copy link
Member Author

@saschanaz can you let us know when gecko has been updated and a link to the relevant issue/patch on the gecko side?

@saschanaz
Copy link
Member

Gecko has not been updated yet, I'll push the button ... ... 20 minutes ago: https://bugzilla.mozilla.org/show_bug.cgi?id=1870037

nondebug
nondebug approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@nondebug nondebug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcoscaceres marcoscaceres mentioned this pull request Feb 21, 2024
Merged
@marcoscaceres
Copy link
Member Author

Thanks @saschanaz!

One last favor, can you review the updated tests (super small pr):
web-platform-tests/wpt#44691

@marcoscaceres marcoscaceres merged commit c207166 into gh-pages Feb 22, 2024
2 checks passed
@marcoscaceres marcoscaceres deleted the secureContext branch February 22, 2024 00:38
@marcoscaceres
Copy link
Member Author

marcoscaceres commented Feb 22, 2024 •
edited
Loading

@msub2 thanks for the reminder about the tests btw! Good catch! (and fixed!!!)

@msub2
Copy link

msub2 commented Feb 22, 2024

No problem! I've been working on Servo's Gamepad implementation so it was pretty fresh in my mind

@marcoscaceres marcoscaceres mentioned this pull request May 9, 2024
Closed
@BlobTheKat
Copy link

I've added a comment to the respective chromium bug to drop the restriction

@partyblob partyblob mentioned this pull request Jun 18, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nondebug nondebug nondebug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please don't restrict to a secure context
5 participants
@marcoscaceres @msub2 @saschanaz @BlobTheKat @nondebug