-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fold touchEvents from extensions.html into index.html #198
base: gh-pages
Are you sure you want to change the base?
Fold touchEvents from extensions.html into index.html #198
Conversation
I believe the failure of the
Should be:
|
b756fd4
to
8ec7959
Compare
8ec7959
to
a4649ca
Compare
I am moving this from "Draft". Any help with spotting the reason for the validate failure is appreciated. Also I think that |
@bradleyneedham, sorry, I just need to double check if this is in scope of the Working Group. I seem to recall there was some concerns from some members around anything "touch" related, so just need to make sure it's all fine. Shouldn't be too long! |
@@ -2238,6 +2451,24 @@ <h2> | |||
</p> | |||
</div> | |||
</section> | |||
<section> | |||
<h3> | |||
Glossary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should really be part of a Model section... or wherever the general idea of gamepad is defined.
index.html
Outdated
Glossary | ||
</h3> | ||
<p> | ||
<dfn>touch surface</dfn> is a surface that can detect contact from a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<dfn>touch surface</dfn> is a surface that can detect contact from a | |
<dfn data-dfn-for="gamepad">touch surface</dfn> is a surface that can detect contact from a |
index.html
Outdated
users fingers and report where on the surface the contact is made. | ||
</p> | ||
<p> | ||
<dfn>touch surface enumeration order</dfn> is an ordered listing of all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<dfn>touch surface enumeration order</dfn> is an ordered listing of all | |
<dfn data-dfn-for="gamepad">touch surface enumeration order</dfn> is an ordered listing of all |
the surfaces in a |gamepad|. | ||
</p> | ||
<p> | ||
<dfn>active touch point</dfn> is defined in the <a href= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a concept we can maybe use from Pointer Events instead?
index.html
Outdated
`null` | ||
</td> | ||
<td> | ||
List of generated touch events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so... are these really touch "events"? If we look at GamepadTouch
, it's not an "Event" at all, so this is a misnomer.
They are more like snapshots of touch points.
index.html
Outdated
@@ -460,6 +472,26 @@ <h2> | |||
</li> | |||
</ol> | |||
</dd> | |||
<dt> | |||
<dfn>touchEvents</dfn> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above... I think it's incorrect to call these "touch events". They are activation points on the track pad at some specific moment in time.
<ol class="algorithm"> | ||
<li>Let |surfaceId:unsigned long| be 0. | ||
</li> | ||
<li>Remove any existing events from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to assume the gamepad is a live object? I don't think this correct. Each gamepad object is just a snapshot in time.
index.html
Outdated
[Exposed=Window, SecureContext] | ||
interface GamepadTouch { | ||
readonly attribute unsigned long touchId; | ||
readonly attribute octet surfaceId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems confusing... wouldn't it be better is gamepad had an unordered touch surface map with named surfaces? Could that be a thing?
const trackpad = gamepad.touchSufaces.get("trackpad");
index.html
Outdated
</p> | ||
<pre class="idl"> | ||
[Exposed=Window, SecureContext] | ||
interface GamepadTouch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interface GamepadTouch { | |
dictionary GamepadTouch { |
index.html
Outdated
<pre class="idl"> | ||
[Exposed=Window, SecureContext] | ||
interface GamepadTouch { | ||
readonly attribute unsigned long touchId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readonly attribute unsigned long touchId; | |
unsigned long touchId; |
index.html
Outdated
[Exposed=Window, SecureContext] | ||
interface GamepadTouch { | ||
readonly attribute unsigned long touchId; | ||
readonly attribute octet surfaceId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readonly attribute octet surfaceId; | |
octet surfaceId; |
index.html
Outdated
readonly attribute Float32Array position; | ||
readonly attribute Uint32Array? surfaceDimensions; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readonly attribute Float32Array position; | |
readonly attribute Uint32Array? surfaceDimensions; | |
Float32Array position; | |
Uint32Array surfaceDimensions; |
index.html
Outdated
@@ -153,6 +153,7 @@ <h2> | |||
readonly attribute GamepadMappingType mapping; | |||
readonly attribute FrozenArray<double> axes; | |||
readonly attribute FrozenArray<GamepadButton> buttons; | |||
readonly attribute FrozenArray<GamepadTouch>? touchEvents; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readonly attribute FrozenArray<GamepadTouch>? touchEvents; | |
readonly attribute FrozenArray<GamepadTouch>? touches; |
Just getting to back to this and wanted to verify our discussion at the last meeting.
|
If I remember correctly, we decided on maplike interfaces for the
|
index.html
Outdated
`null` | ||
</td> | ||
<td> | ||
List of generated touch events. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List of generated touch events. | |
List of touches. |
926ef0f
to
0d65b74
Compare
Partially Closes #165
The following tasks have been completed:
Implementation commitment:
Standards positions:
Resources:
Preview | Diff