Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: github action to run prettier #10

Closed
wants to merge 17 commits into from
Closed

chore: github action to run prettier #10

wants to merge 17 commits into from

Conversation

pkra
Copy link
Member

@pkra pkra commented Jun 26, 2023

A first test

@pkra pkra requested a review from jnurthen June 26, 2023 11:24
@pkra
Copy link
Member Author

pkra commented Jun 26, 2023

@jnurthen I thought we'd try a smaller spec first.

@pkra
Copy link
Member Author

pkra commented Jun 26, 2023

Some notes

  • graphics2.html had an unclosed section, throwing prettier off; I've temporarily fixed it
  • I've set prettier's print-width to 200 which seemed decent. (I don't think we can set it to Number.POSITIVE_INFINITY via the CLI options -- but we could go 9999 or some such if people prefer.)

fetch-depth: 0

- name: Prettify code
uses: creyD/prettier_action@v4.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to pair this with a Dependabot config like https://github.com/w3c/aria-practices/blob/83d1329687a9f3e35737ff1a49bb2678eab02c15/.github/dependabot.yml#L11 to keep this Action up-to-date

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nschonni. I've made a note. Let's see if this actually makes it first though 😄

@pkra pkra requested a review from nschonni October 17, 2023 07:53
@pkra
Copy link
Member Author

pkra commented Oct 17, 2023

@jnurthen would you take another look?

pkra added a commit to w3c/svg-aam that referenced this pull request Oct 27, 2023
 Matches w3c/graphics-aria#10, including dependabot for the action.
pkra added a commit to w3c/dpub-aria that referenced this pull request Oct 27, 2023
Matches w3c/graphics-aria#10, including dependabot for the action.
pkra added a commit to w3c/aria that referenced this pull request May 20, 2024
Matches w3c/graphics-aria#10, including dependabot for the action.
@pkra
Copy link
Member Author

pkra commented May 22, 2024

Overcome by events.

@pkra pkra closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants