Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note on now() in backgrounded tabs #69

Merged
merged 3 commits into from
May 14, 2019

Conversation

yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented May 13, 2019

Closes #65


Preview | Diff

@yoavweiss yoavweiss requested review from igrigorik and npm1 May 13, 2019 08:48
index.html Outdated
@@ -341,6 +341,10 @@ <h3>Monotonic Clock</h3>
properties only apply for contexts that can reach other by exchanging
messages via one of the provided messaging mechanisms - e.g. `postMessage`,
`BroadcastChannel`, etc.</p>
<p class="note">The user agent needs to make sure that the monotonic clock of
backgrounded tabs continues to advance at the same speed as the system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think 'same speed as the system clock' is valid. In fact, the monotonic clock is not supposed to be subject to system clock skew.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some user agents can chose to throttle timers and callbacks in certain conditions, for example when a tab is backgrounded, this should not affect the resolution or accuracy of time passed surfaced by the monotonic clock.

Warmer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

Copy link
Member

@igrigorik igrigorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

But I'll defer to @npm1 to sanity check before we merge.

index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo typo

Co-Authored-By: npm1 <npm@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can performance.now() timers be frozen for background tabs, etc?
3 participants