Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inconsistency nits #269

Merged
merged 2 commits into from
Dec 10, 2019
Merged

fix inconsistency nits #269

merged 2 commits into from
Dec 10, 2019

Conversation

carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Dec 2, 2019 •
edited by pr-preview bot
Loading

Just fixing a few tiny inconsistencies in the markup for easier parsing and linking (no actual content words were changed):

  • ensure all table entries use the same markup: <tr tabindex="-1" id="el-x"> (2 of them had tabindex="-1" after id) (consistency makes the spec easier to parse... :)
  • the table entry with id="el-header2" is actually a special case of form element (not header), so used "el-form-no-accessible-name" instead
  • use hyphen to separate words in id's for consistent naming with ARIA in HTML, i.e. "el-img-empty-alt" (not "emptyalt")

Preview | Diff

@scottaohara
Copy link
Member

Marked as non substantive for IPR from ash-nazg.

scottaohara
scottaohara approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Travis build issues

@carmacleod
Copy link
Contributor Author

@marcoscaceres I think this is the same respec error as for #271

@carmacleod carmacleod mentioned this pull request Dec 9, 2019
Merged
@marcoscaceres
Copy link
Member

Yep... working hard to get you all a fix it! Will do my best to have something tomorrow! 🙏

@scottaohara scottaohara merged commit 45389a7 into w3c:gh-pages Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carmacleod @scottaohara @marcoscaceres