-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up id and tabindex in docconformance table rows #181
Comments
Thanks @carmacleod. |
Any opinions on the items in the "Not sure" list above? I could go either way on those. |
per talking to @carmacleod some more about this offline, reopening for further updates. |
Decision was to go with:
Note that this naming scheme makes id's consistent with the HTML-AAM spec. Also decided that only one id is needed for each element/type/attribute because planned consolidation will place related entries next to one another. |
Oef, that sounds dangerous to me. As it stands it’s super easy to link to a specific part. I would regret it if that wasn’t possible anymore in the future. |
i don't think it will be an issue. also, as work is still going on here, better to plan for what we know is going to be available, vs a bunch of ids that will need changing. |
Tidying up even more, with a new PR: #183 @ZoeBijl For now, the specific direct links are still there. The first link to an element entry uses The only inconsistent one is
... but that one was inconsistent before, so I don't feel too bad about leaving it like that for now. ;) I'm sure @scottaohara will figure out a nice way to consolidate those... :) perhaps by creating new |
In hopeful preparation for linking into the ARIA in HTML spec from the HTML element specs, need to ensure that row
id
's in the docconformance table are all present and robustly named, and thattabindex="-1"
is consistently added to each row.For example:
anohref
->a-no-href
figcaption
,input-color
,param
,attr-contenteditable
input-color
->input-date
,input-datetime
->input-datetime-local
,source2
->slot
,dd-dt
->dd
,dd-dt2
->dt
tabindex="-1"
forinput-color
,param
autonomous-custom-elemenet
->autonomous-custom-element
TD
->td
el-title
->title
Not sure what to do about:
img-alt
,img
,img-no-alt
... maybe change toimg-alt-empty
,img-alt
,img-no-alt
?-no-list
toinput-email
,input-tel
,input-text
,input-url
or remove
-no-list
frominput-search-no-list
?select
/select2
... maybe change toselect-no-multiple-no-size-greater-1
/select-multiple-or-size-greater-1
? (or is that too complex)tbody-tfoot-thead
- alphabetical order, or logical order (thead before tfoot)?I will provide an initial PR for this shortly.
The text was updated successfully, but these errors were encountered: