update allowances for figure #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a figure has a figcaption descendant, the expected parent/child relationship needs to be maintained, so the figure cannot have a role. if there is no figcaption descendant, then the figure could receive any role. this commit also alphabetizes fieldset and figcaption correctly in the table.
stevefaulkner
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a figure has a figcaption descendant, the expected parent/child relationship needs to be maintained, so the figure cannot have a role.
if there is no figcaption descendant, then the figure can receive any role.
this commit also alphabetizes fieldset and figcaption correctly in the table.
note the issue branch is incorrect, this update will close #99
Preview | Diff