Addition: update figure role allowances #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #412 As discussed in w3c/dpub-aria#42 (comment), `doc-example` is a dpub variant of the `figure` role. This role being the same as `figure` but with the opportunity of being exposed as an "example" for its role description, needs to be an allowed role for the `figure` element.
scottaohara
added
needs implementation commitment
This was referenced Apr 16, 2022
scottaohara
commented
Apr 26, 2022
stevefaulkner
approved these changes
Jul 13, 2022
stevefaulkner
approved these changes
Feb 6, 2023
|
merging as arc toolkit and axe do not report errors when using this role on figure element |
scottaohara
added
Meets 2 implementations req
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #412
As discussed in w3c/dpub-aria#42 (comment),
doc-exampleis a dpub variant of thefigurerole. This role being the same asfigurebut with the opportunity of being exposed as an "example" for its role description, needs to be an allowed role for thefigureelement.create test case
Expected results:
doc-exampleis an allowed role for<figure role=doc-example>...<figcaption>...</figcaption>figureresults in a warning as unnecessary for<figure role=figure>...<figcaption>...</figcaption>no other roles are allowed if a
figcaptionis a child of afigureelement.Preview | Diff