This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
add the allowusermedia attr to iframe #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaals
suggested changes
Nov 28, 2017
chaals
reviewed
Nov 28, 2017
| @@ -4035,6 +4037,8 @@ My <img src="heart.png" alt="heart"> breaks. | |||
| are to be <a>allowed to use</a> the <a><code>PaymentRequest</code></a> interface | |||
| to make payment requests. | |||
|
|
|||
| The <dfn element-attr for="iframe"><code>allowusermedia</code></dfn> attribute is a <a>boolean attribute</a>. When specified, it indicates that {{Document}} objects in the <{iframe}> element's <a>browsing context</a> are to be <a>allowed to use</a> {{Element/getUserMedia()}} (if it's not blocked for other reasons, e.g. there is another ancestor <{iframe}> without this attribute set). | |||
|
|
|||
There was a problem hiding this comment.
please break up this line to 80-100 characters per line
|
@chaals done! thanks for the review. |
plehegar
pushed a commit
that referenced
this pull request
Dec 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #778 .
Need to solve #1086 before merging this pull request.