This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
Remove scoped style #318
Merged
Remove scoped style #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likely will want to change the example with 2 video elements and inline style due to the removal of 'scoped'. Suggested alternates most welcome. |
| <div> | ||
| <video src="movie.vid#track=Video&amp;track=English" autoplay controls mediagroup=movie></video> | ||
| <video src="movie.vid#track=sign" autoplay mediagroup=movie></video> | ||
| <div style="{ margin: 1em auto; position: relative; width: 400px; height: 300px; }"> |
There was a problem hiding this comment.
style attribute value should not contain { }
|
Other than Arron's comment, this looks good. I did note one thing: in one example, you promote the styles to the head, but in the table example, you remove them entirely. Essential vs. non-essential styles? |
|
Good catch on the curlys, thanks. @travisleithead yes, the table example didn't need the styles at all but the other example breaks without them, and without scoped they need to be in the head. |
ExplodingCabbage
added a commit
to ExplodingCabbage/html-1
that referenced
this pull request
Jul 7, 2016
These were true when the index of elements was introduced, but obsoleted when w3c#318 removed the scoped attribute. Resolves w3c#516 (This commit is an exact duplicate of whatwg/html@2acc100)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #231