Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Referrer policy #954

Merged
merged 19 commits into from
Jul 5, 2017
Merged

Referrer policy #954

merged 19 commits into from
Jul 5, 2017

Conversation

adanilo
Copy link

@adanilo adanilo commented Jun 22, 2017

Changes for Issue #560 plus some manual diffs for referrerpolicy at various places in the spec. that weren't obvious from the issue.

<a>removed from the document</a>, or existing <code>meta</code> elements have their <code>name</code>
or <code>content</code> attributes changed, user agents must run the following algorithm:

<ol>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use the short hand ol list syntax.

Copy link
Contributor

@arronei arronei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 2 comments but only the link wrapping one is necessary to correct. Once that is corrected anyone can merge this. The rest of this is fine.

@@ -963,6 +974,75 @@
inappropriate keywords.
</p>

: <dfn><code>referrer</code></dfn>

:: The value must be a <a>referrer policy</a>, which defines the default <a>referrer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping a link is bad. Could you fix this one link so we don't line break in the middle of an link element.

@adanilo
Copy link
Author

adanilo commented Jun 30, 2017

Fixes for review are in d9217b6 - could someone check and merge please?

Copy link
Collaborator

@chaals chaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this seems good to go now - thanks.

@chaals chaals dismissed arronei’s stale review July 5, 2017 12:19

Alex seems to have made the change requested

@chaals chaals merged commit 8b477d2 into w3c:master Jul 5, 2017
plehegar pushed a commit that referenced this pull request Jul 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants