Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #textOrientation-sideways-LR listed twice #373

Closed
spoeschel opened this issue Apr 26, 2018 · 4 comments
Closed

Feature #textOrientation-sideways-LR listed twice #373

spoeschel opened this issue Apr 26, 2018 · 4 comments
Assignees
Milestone

Comments

@spoeschel
Copy link

spoeschel commented Apr 26, 2018

In §6, the feature #textOrientation-sideways-LR is listed twice - with different dispositions for the Text profile.

@nigelmegitt
Copy link
Contributor

Thanks for this @spoeschel , this is a substantive issue.

@nigelmegitt nigelmegitt changed the title Feature #textOrientation-sideways-L listed twice Feature #textOrientation-sideways-LR listed twice Apr 26, 2018
@css-meeting-bot
Copy link
Member

The Working Group just discussed Feature #textOrientation-sideways-L listed twice imsc#373, and agreed to the following resolutions:

  • SUMMARY: This needs a bit of digging to find out what we meant and wanted. To do!
The full IRC log of that discussion <nigel> Topic: Feature #textOrientation-sideways-L listed twice imsc#373
<nigel> github: https://github.com//issues/373
<nigel> Nigel: This is substantive - it isn't clear what the disposition for #textOrientation-sideways-LR is
<nigel> .. as Stefan spotted.
<nigel> Cyril: Given that #textOrientation itself is completely prohibited, maybe #textOrientation-sideways-LR
<nigel> .. is also prohibited, but maybe we need to dig into the history on this.
<nigel> Pierre: I have not had time to review that. I don't want to guess!
<nigel> .. It will get done.
<nigel> SUMMARY: This needs a bit of digging to find out what we meant and wanted. To do!

@nigelmegitt
Copy link
Contributor

I've checked the definition of #textOrientation and it indeed appears that prohibiting #textOrientation prohibits all use of it, so permitting any subset of value makes no sense. Therefore there are two options:

  1. Prohibit #textOrientation-sideways-LR in Text and Image profiles, and make no other change.
  2. Make #textOrientation for Text profile partly permitted, and permit or prohibit #textOrientation-sideways-LR for Text Profile depending on what we actually need.

Permitting #textOrientation but prohibiting #textOrientation-sideways-LR means that the value for tts:textOrientation must be one of: "mixed" | "sideways" | "upright" and must not be one of: "sidewaysLeft" | "sidewaysRight". There are no other values for this property defined in TTML2.

@palemieux palemieux added this to the imsc1.1 PR milestone Apr 26, 2018
@palemieux palemieux self-assigned this May 21, 2018
@palemieux
Copy link
Contributor

Prohibit #textOrientation-sideways-LR in Text and Image profiles, and make no other change.

I believe this was the intent since #textOrientation is not a requirement.

palemieux added a commit that referenced this issue Jun 21, 2018
Add support for negative values (#370, #394)
Clarify support for #textOrientation-sideways-LR (#373)
Added #extent-length (#382)
Move tts:position constraints to Text Profile (#392)
Fix localBiblio bug
palemieux added a commit that referenced this issue Jun 28, 2018
Add support for negative values (#370, #394)
Clarify support for #textOrientation-sideways-LR (#373)
Added #extent-length (#382)
Move tts:position constraints to Text Profile (#392)
Fix localBiblio bug
Replace tts:fontShear with tts:shear and tts:lineShear (#401)
@palemieux palemieux removed the pr open label Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants