Update "magnetometer" permission reference #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reillyeon
requested changes
May 7, 2024
anssiko
commented
May 7, 2024
reillyeon
requested changes
May 8, 2024
index.bs
Outdated
| @@ -181,7 +181,7 @@ the Generic Sensor API [[!GENERIC-SENSOR]]. | |||
| Permissions Policy integration {#permissions-policy-integration} | |||
| ============================== | |||
|
|
|||
| This specification defines a [=policy-controlled feature=] identified by the string "<code><dfn data-lt="magnetometer-feature" export>magnetometer</dfn></code>". Its [=default allowlist=] is "`self`". | |||
| This specification utilizes the [=policy-controlled feature=] identified by the string "<code><a data-lt="magnetometer-feature">magnetometer</a></code>". | |||
There was a problem hiding this comment.
The definition of the "magnetometer" permission below needs to be updated to a reference as well.
This fixes duplicate definition. Fix #73
anssiko
force-pushed
the
fix-magnetometer-dupe-export
branch
from
eba3799 to
adb7ac0
Compare
|
@reillyeon thanks for the review. I pushed a squashed and cleaned up version with improvements. |
reillyeon
approved these changes
May 14, 2024
github-actions bot
added a commit
that referenced
this pull request
May 15, 2024
SHA: 94a1116 Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes duplicate definition.
Fix #73
Preview | Diff