Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a lang member #322

Closed
marcoscaceres opened this issue Mar 4, 2015 · 7 comments
Closed

Add a lang member #322

marcoscaceres opened this issue Mar 4, 2015 · 7 comments
Labels
Feature Request P1

Comments

@marcoscaceres
Copy link
Member

Elsewhere, Addison Phillips pointed out:

Language: you still need to provide language information about the manifest's natural
language content items. Among other things, correct font selection rides on providing
language metadata to the text drawing layer. Inferring the language of the text by sniffing
the bits is inaccurate or impractical. The best practice is to provide this as additional
data.

I'm inclined to add a lang member.
@marcoscaceres marcoscaceres changed the title Add a language tag Add a lang member Mar 4, 2015
@mounirlamouri
Copy link
Member

I would suggest to not add 'lang' without a full i18n story. If we were to re-use Mozilla's Manifest way to handle i18n, we might want to have default_locale instead of lang.

@marcoscaceres
Copy link
Member Author

@mounirlamouri

I would suggest to not add 'lang' without a full i18n story.

Please see Addison's comments - this is not related to localization - this is about primary language in which the content of the manifest is written.

And we do have a full i18n story, it's: "adapt your manifest based on user input to your web app... like you do with every other document on your site":).

@marcoscaceres
Copy link
Member Author

@mounirlamouri still want your ok on this: cbd8343

@benfrancis
Copy link
Member

Note that:

  • Having multiple manifest files per app prevents the manifest URL being used as an app identifier.
  • Having a dynamically generated manifest prevents the manifest being signed for the purpose of granting permissions.

I know that neither of these requirements are things that everyone agrees on, but I wanted to call out that they may make certain things impossible in the future.

And FWIW I don't actually think having multiple locales in a single manifest is particularly messy.

@marcoscaceres
Copy link
Member Author

On March 7, 2015 at 5:21:38 AM, Ben Francis (notifications@github.com) wrote: 

And FWIW I don't actually think having multiple locales in a single manifest is particularly
messy.

There seems to be some confusion about the use case: having lang helps with font selection for the purposes of display (please, all, read Addison's email carefully!), which is different to the localization that is used by Mozilla's manifest format or the alternatives proposed in other bugs. 

That is to say, default_locale, if it was ever to be added, works independently of lang. It's like <html lang=> or <foo xml:lang>. 

@mounirlamouri
Copy link
Member

But if we end up having some locales array like the Firefox Manifest, lang might be a bit pointless? Or would you re-use lang in there and it would apply for the scope? In which case, the way we would handle override would be a tad different from what Mozilla currently do. If you have no problem with that, I'm fine with adding lang. (Note, I think it would kill default_locale too.)

@marcoscaceres
Copy link
Member Author

But if we end up having some locales array like the Firefox Manifest, lang might be a bit pointless?

No, because lang is still the primary language (i.e., it's the same as default_locale).

Or would you re-use lang in there and it would apply for the scope? In which case, the way we would handle override would be a tad different from what Mozilla currently do.

That's fine. Mozilla's model leads to very unmanageable nested structures.

If you have no problem with that, I'm fine with adding lang. (Note, I think it would kill default_locale too.)

I'm fine. I'll take this as agreement. 👍

marcoscaceres pushed a commit that referenced this issue Mar 10, 2015
Merge pull request #324 from w3c/lang
777f716 
Added lang member (closes #322)
marcoscaceres added a commit that referenced this issue Mar 12, 2015
@marcoscaceres
Added lang member (closes #322)
32d7323
@marcoscaceres marcoscaceres mentioned this issue Mar 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benfrancis @mounirlamouri @marcoscaceres