-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an Uninstallation section. #678
Conversation
@mgiuca Could your |
@tomayac RECOMMENDED and SHOULD have the same meaning: https://www.ietf.org/rfc/rfc2119.txt |
Wow, #TIL. To me, if something "should" be a certain way sounds stronger than if something is "recommended" to be a certain way. Luckily the RFC has us non-native speakers covered. Thanks for teaching me. Sorry for the noise. |
index.html
Outdated
</h3> | ||
<p> | ||
User agents SHOULD provide a mechanism for the user to remove the | ||
installed app from the system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"from the system" might be overly specific... a UA can "install" a web app to, for example, the new tab page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just drop that part then... apart from that lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
The section recommends other cleanup activities besides removing the application. Addresses w3c#636.
It isn't really a non-native-English thing. I think informally, "should" is stronger than "recommended". "You should clean your room" is stronger than "I recommend that you clean your room". To be honest, the way I wrote this was (despite the RFC prescribing these words the exact same meaning) intentionally to make the first statement a little stronger than the first. Obviously there should be an uninstall process (though we can't mandate it). It seems a little less necessary that the UA offer to clean up related settings and things, especially since the scopes may not exactly match (lots of these permissions are origin-scoped, which may be overly broad), so it's not obvious even how to do this correctly. So I could have written it more forcefully as "The user agent SHOULD also present the user with an opportunity..." but I deliberately chose a passive voice, "It is RECOMMENDED that at the time of removal, the user agent also presents the user with an opportunity...", because it's less clear whether or how to do this. |
The section recommends other cleanup activities besides removing the
application.
Addresses #636.
Preview | Diff