Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an Uninstallation section. #678

Merged
merged 1 commit into from
May 23, 2018
Merged

Conversation

mgiuca
Copy link
Collaborator

@mgiuca mgiuca commented May 22, 2018

The section recommends other cleanup activities besides removing the
application.

Addresses #636.


Preview | Diff

@tomayac
Copy link
Contributor

tomayac commented May 22, 2018

@mgiuca Could your RECOMMENDED become a stronger SHOULD, reflecting user expectations?

@mgiuca
Copy link
Collaborator Author

mgiuca commented May 22, 2018

@tomayac RECOMMENDED and SHOULD have the same meaning: https://www.ietf.org/rfc/rfc2119.txt

@tomayac
Copy link
Contributor

tomayac commented May 22, 2018

Wow, #TIL. To me, if something "should" be a certain way sounds stronger than if something is "recommended" to be a certain way. Luckily the RFC has us non-native speakers covered. Thanks for teaching me. Sorry for the noise.

index.html Outdated
</h3>
<p>
User agents SHOULD provide a mechanism for the user to remove the
installed app from the system.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"from the system" might be overly specific... a UA can "install" a web app to, for example, the new tab page.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just drop that part then... apart from that lgtm

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@mgiuca mgiuca force-pushed the recommend-cleanup branch from 21cb3c8 to b4e49ef Compare May 23, 2018 01:10
The section recommends other cleanup activities besides removing the
application.

Addresses w3c#636.
@mgiuca mgiuca force-pushed the recommend-cleanup branch from b4e49ef to 96ffa05 Compare May 23, 2018 01:12
@mgiuca
Copy link
Collaborator Author

mgiuca commented May 23, 2018

@tomayac

Wow, #TIL. To me, if something "should" be a certain way sounds stronger than if something is "recommended" to be a certain way. Luckily the RFC has us non-native speakers covered.

It isn't really a non-native-English thing. I think informally, "should" is stronger than "recommended". "You should clean your room" is stronger than "I recommend that you clean your room".

To be honest, the way I wrote this was (despite the RFC prescribing these words the exact same meaning) intentionally to make the first statement a little stronger than the first. Obviously there should be an uninstall process (though we can't mandate it). It seems a little less necessary that the UA offer to clean up related settings and things, especially since the scopes may not exactly match (lots of these permissions are origin-scoped, which may be overly broad), so it's not obvious even how to do this correctly.

So I could have written it more forcefully as "The user agent SHOULD also present the user with an opportunity..." but I deliberately chose a passive voice, "It is RECOMMENDED that at the time of removal, the user agent also presents the user with an opportunity...", because it's less clear whether or how to do this.

@mgiuca mgiuca merged commit 128fbca into w3c:gh-pages May 23, 2018
@mgiuca mgiuca deleted the recommend-cleanup branch June 13, 2018 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants