Make setMicrophoneActive and setCameraActive return promises. #312
+122
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jan-ivar, @steimelchrome, PTAL. |
jan-ivar
suggested changes
Jan 12, 2024
index.bs
Outdated
Comment on lines
85
to
90
| urlPrefix: https://www.w3.org/TR/mediacapture-streams/; spec: mediacapture-main | ||
| type: dfn | ||
| text: MediaStreamTrack; url:#mediastreamtrack | ||
| text: MediaStreamTrack muted state; url:#track-muted | ||
| text: set MediaStreamTrack muted state; url:#set-track-muted |
There was a problem hiding this comment.
Can we get these exported properly from the other spec if needed?
There was a problem hiding this comment.
How does w3c/mediacapture-main#986 look?
There was a problem hiding this comment.
You may to update https://w3c.github.io/mediasession/#example-microphone-camera-hangup as well
jan-ivar
suggested changes
Jan 22, 2024
youennf
force-pushed
the
enable-asynchronous-errors-insetActive-methods
branch
from
8ccde85
to
79293d8
Compare
This was referenced Jan 30, 2024
Let's do that in a follow-up, given the examples are still ok, at least in Chrome. |
Define steps for each of these methods. Mention the possibility to mute/unmute tracks based on setMicrophoneActive/setCameraActive calls. Mention the possibility for the user agent to deny the mutation of capture states via setMicrophoneActive/setCameraActive calls.
youennf
force-pushed
the
enable-asynchronous-errors-insetActive-methods
branch
from
79293d8
to
772f0ec
Compare
jan-ivar
reviewed
Feb 2, 2024
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
jan-ivar
reviewed
Feb 2, 2024
jan-ivar
reviewed
Feb 3, 2024
jan-ivar
reviewed
Feb 13, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 15, 2024
SHA: fac2b9a Reason: push, by youennf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define steps for each of these methods.
Mention the possibility to mute/unmute tracks based on setMicrophoneActive/setCameraActive calls. Mention the possibility for the user agent to deny the mutation of capture states via setMicrophoneActive/setCameraActive calls.
Preview | Diff