-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish media streaming (session start, stats) #172
Conversation
Make requirements for remote playback address flinging specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now I think it's ready for another look.
index.bs
Outdated
made for encodings by sending a streaming-session-modify-request | ||
containing a modify list of stream-requests. When the sender receives | ||
a streaming-session-modify-request, it should send back a | ||
streaming-session-modify-response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's basically just an OK/error response.
Specify codec names using RFC 6381
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like some of the typos weren't fixed yet - maybe there needs to be another commit pushed?
index.bs
Outdated
made for encodings by sending a streaming-session-modify-request | ||
containing a modify list of stream-requests. When the sender receives | ||
a streaming-session-modify-request, it should send back a | ||
streaming-session-modify-response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some text to clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a commit to rebase and fix the typos.
OK, I think I got everything other than the two things we'll include in separate PRs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left a few minor things to fix before merging.
index.bs
Outdated
@@ -1005,6 +1010,18 @@ invalid-url). Additionally, the response must include the following: | |||
:: The initial state of the remote playback, as defined in | |||
[[#remote-playback-state-and-controls]]. | |||
|
|||
: remoting (optional) | |||
:: A response to the started streaming session associatd with this remote playback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: Fix typo before merging
index.bs
Outdated
|
||
During a streaming session, the receiver can modify the requests it | ||
made for encodings by sending a `streaming-session-modify-request` | ||
containing a modify list of stream-requests. When the sender receives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: Fix typo before merging
index.bs
Outdated
contains an arbitrary payload that can be synchronized with and video, such as | ||
text track data. A series of data frames that share a data type and timeline | ||
contains an arbitrary payload that can be synchronized with audio and video. | ||
A series of data frames that share a data type and timeline | ||
form a data encoding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: Fix line wrapping
Also remove streaming data, since it doesn't really have a use case
Preview | Diff