Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish media streaming (session start, stats) #172

Merged
merged 71 commits into from
Sep 10, 2019
Merged

Conversation

pthatcherg
Copy link
Contributor

@pthatcherg pthatcherg commented May 23, 2019

Also remove streaming data, since it doesn't really have a use case


Preview | Diff

Copy link
Contributor Author

@pthatcherg pthatcherg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now I think it's ready for another look.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated
made for encodings by sending a streaming-session-modify-request
containing a modify list of stream-requests. When the sender receives
a streaming-session-modify-request, it should send back a
streaming-session-modify-response.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's basically just an OK/error response.

index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
messages_appendix.cddl Show resolved Hide resolved
messages_appendix.cddl Show resolved Hide resolved
Copy link
Contributor

@markafoltz markafoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some of the typos weren't fixed yet - maybe there needs to be another commit pushed?

index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated
made for encodings by sending a streaming-session-modify-request
containing a modify list of stream-requests. When the sender receives
a streaming-session-modify-request, it should send back a
streaming-session-modify-response.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some text to clarify?

index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
messages_appendix.cddl Show resolved Hide resolved
messages_appendix.cddl Show resolved Hide resolved
Copy link
Contributor

@markafoltz markafoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit to rebase and fix the typos.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@pthatcherg
Copy link
Contributor Author

OK, I think I got everything other than the two things we'll include in separate PRs:

  1. Codec switching when remoting
  2. Requesting someone send you a streaming session.

Copy link
Contributor

@markafoltz markafoltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I left a few minor things to fix before merging.

index.bs Outdated
@@ -1005,6 +1010,18 @@ invalid-url). Additionally, the response must include the following:
:: The initial state of the remote playback, as defined in
[[#remote-playback-state-and-controls]].

: remoting (optional)
:: A response to the started streaming session associatd with this remote playback.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Fix typo before merging

index.bs Outdated

During a streaming session, the receiver can modify the requests it
made for encodings by sending a `streaming-session-modify-request`
containing a modify list of stream-requests. When the sender receives
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Fix typo before merging

index.bs Outdated
contains an arbitrary payload that can be synchronized with and video, such as
text track data. A series of data frames that share a data type and timeline
contains an arbitrary payload that can be synchronized with audio and video.
A series of data frames that share a data type and timeline
form a data encoding.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: Fix line wrapping

@markafoltz markafoltz merged commit 96dca50 into gh-pages Sep 10, 2019
@markafoltz markafoltz deleted the streaming2 branch September 18, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants