Renaming PaymentApp* classes

[tommythorsen]

Now that we've renamed to our specification to Payment Handler API, I think it would make sense to not name our classes starting with PaymentApp. I don't think it's super elegant to just rename everything to PaymentHandler*, so I'm looking at alternatives. The first classes I wanted to consider was the following:

5.2 PaymentAppManager interface
5.3 PaymentAppOptions interface
5.4 PaymentAppOption dictionary
5.5 PaymentWallets interface
5.6 WalletDetails interface

I think PaymentAppManager can just become PaymentManager, but PaymentAppOptions can not be renamed to PaymentOptions, as that would cause a name conflict with a class in the Payment Request API specification.

When talking about digital payments, one often talk about a digital wallet containing a set of digital payment instruments. So, how about PaymentInstrument? I realize it's a term with very specific meaning, but I think that it actually fits quite well here.

I would also suggest renaming WalletDetails to be consistent with the other names, so that we would end up with the following set of classes:

5.2 PaymentManager interface
5.3 PaymentInstruments interface
5.4 PaymentInstrument dictionary
5.5 PaymentWallets interface
5.6 PaymentWallet dictionary

WDYT?

[rsolomakhin]

SGTM

[pjbazin]

+1 III Pascal BAZIN<http://gsearch.gemalto.com/search/people/detailspeople.jsp?q=gin:10021956> From: Tommy Thorsen [mailto:notifications@github.com] Sent: jeudi 16 mars 2017 13:59 To: w3c/webpayments-payment-apps-api <webpayments-payment-apps-api@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [w3c/webpayments-payment-apps-api] Renaming PaymentApp* classes (#109) Now that we've renamed to our specification to Payment Handler API, I think it would make sense to not name our classes starting with PaymentApp. I don't think it's super elegant to just rename everything to PaymentHandler*, so I'm looking at alternatives. The first classes I wanted to consider was the following: 5.2 PaymentAppManager interface 5.3 PaymentAppOptions interface 5.4 PaymentAppOption dictionary 5.5 PaymentWallets interface 5.6 WalletDetails interface I think PaymentAppManager can just become PaymentManager, but PaymentAppOptions can not be renamed to PaymentOptions, as that would cause a name conflict with a class in the Payment Request API specification. When talking about digital payments, one often talk about a digital wallet containing a set of digital payment instruments. So, how about PaymentInstrument? I realize it's a term with very specific meaning, but I think that it actually fits quite well here. I would also suggest renaming WalletDetails to be consistent with the other names, so that we would end up with the following set of classes: 5.2 PaymentManager interface 5.3 PaymentInstruments interface 5.4 PaymentInstrument dictionary 5.5 PaymentWallets interface 5.6 PaymentWallet interface WDYT? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#109>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATacMZrVwAO-Ks3Jyx0dCroua16rvSQ8ks5rmTISgaJpZM4MfQzl>.

…

________________________________ This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited. E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender. Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a transmitted virus.

[adrianhopebailie]

I have an action to go through and fix this as soon as @ianbjacobs and @adamroach have finished the edits they wanted to make before the f2f.

@tommythorsen - If you're already working on it let me know.

[tommythorsen]

@adrianhopebailie: I am not working on this.

Are there major changes incoming? I was thinking to go through the respec warnings and sort those out at some point, but I don't want to create a lot of conflicts for people.

[ianbjacobs]

Hi @tommythorsen,

Let's wait for @adamroach's edits and then do a cleanup pass (e.g., early next week).

Ian

[adamroach]

I'm making these changes in my edits as well. It would be worthwhile for someone to come behind me and make sure I didn't miss anything. :)

[tommythorsen]

Most of this has been dealt with by #113, but @adamroach: what's the point of the inconsistently named WalletDetails? Is there a good reason for choosing this name?

Can we either rename WalletDetails to PaymentWallet or PaymentInstrument to InstrumentDetails so that the names match?

[adamroach]

@tommythorsen -- Sorry, no real principled reason for having them different. Feel free to adjust them to be consistent.

[ianbjacobs]

Today we resolved [1] to harmonize using the convention of "Payment" as a prefix. Thus, we chose PaymentWallet and I'll update the spec accordingly.

[1] https://www.w3.org/2017/04/04-apps-minutes#item03

[tommythorsen]

Great! Since you have an action on you to make the change, I don't think we need this issue, so I'll close it.