Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update complete() method to take a string and clarify its purpose #161

Closed
wants to merge 2 commits into from
Closed

Update complete() method to take a string and clarify its purpose #161

wants to merge 2 commits into from

Commits on Apr 27, 2016

  1. Update complete() method to take a string and clarify its purpose 

    The argument to complete is used to influence the user experience as the
user interface for the payment request is dismissed. Some sites will not
be able to provide an indication of success (perhaps because they
require additional flow steps after the payment request before accepting
an order). Calling complete() with no arguments uses the default value
where success or failure are not indicated.

NOTE: the current WebIDL parser used by Respec does not handle default
values for enums though these are allowed in WebIDL. This results in a
Respect error once this change is merged.
    @adrianba
    adrianba committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    3238fb9 View commit details
    Browse the repository at this point in the history

  2. Fix optional argument.

    @adrianba
    adrianba committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    9872966 View commit details
    Browse the repository at this point in the history