Add reference to issue #47. #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var payment = navigator.payment.request(request); | ||
| </pre> | ||
| </div> | ||
|
|
||
| <p>The following example shows how to construct a <a><code>PaymentRequest</code></a> and begin the |
There was a problem hiding this comment.
@msporny Can you reword this to be a lot simpler and leave the deeper explanation for users to read in the issue itself? I would also suggest placing this issue marker alongside those for #15 and #16 which also relate to the shape of the API.
Suggestion:
<div class="issue" data-number="47" title="Should a payment request be just data, or a
programmable object?"> There is an open issue about whether the payment request should
be a programmable object or should be just pure data that can be operated on by methods.</div>
|
@adrianhopebailie wrote:
Done and moved to where you suggested. |
|
Merged as 814702c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reference to issue #47.