Define concepts for converting and validating .data
#977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmcgruer
force-pushed
the
smcgruer/early_validation_specified
branch
from
7a6cfe4
to
c3d0335
Compare
|
@marcoscaceres - fyi this is my suggestion for adding a |
marcoscaceres
requested changes
Nov 22, 2021
marcoscaceres
changed the title
|
cc @ianbjacobs as landing this blocks w3c/secure-payment-confirmation#194 The build is currently failing because the upstream of this PR (#976) is behind HEAD and needs updated to include 34c206f |
stephenmcgruer
added a commit
to w3c/secure-payment-confirmation
that referenced
this pull request
Jun 30, 2022
marcoscaceres
previously requested changes
Jul 6, 2022
This makes it easier for other specifications to clearly indicate their defined steps to convert and validate the data member.
stephenmcgruer
force-pushed
the
smcgruer/early_validation_specified
branch
from
2b4692a
to
a389afa
Compare
stephenmcgruer
changed the title
.data
Good catch - thanks for noticing this! I've updated the PR description and title (along with addressing your other comments) to reflect that new errors may be thrown. |
marcoscaceres
approved these changes
Jul 7, 2022
stephenmcgruer
added a commit
to w3c/secure-payment-confirmation
that referenced
this pull request
Jul 7, 2022
marcoscaceres
added a commit
that referenced
this pull request
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new definitions (
dfn) for both the IDL type thatPaymentMethodData/datashould be converted into, and for the validationsteps that a payment method will perform on it. This allows payment method
specs to define these in a way that is cross-linkable to the PaymentRequest
specification.
This change is mostly editorial, except that it allows for arbitrary error types
to be thrown during validation (previously only
TypeErrorwould be thrown).Preview | Diff