Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of jyasskin's draft #74

Closed
annevk opened this issue Apr 1, 2016 · 2 comments
Closed

Review of jyasskin's draft #74

annevk opened this issue Apr 1, 2016 · 2 comments

Comments

@annevk
Copy link
Member

annevk commented Apr 1, 2016

I reviewed https://rawgit.com/jyasskin/permissions/allow-choosers/index.html

  1. Everything that is associated with a permission should default to the "binary" (rename to boolean?) options. There's no need to repeat that for each of them.
  2. Since the majority are boolean, there should be a simple way to get and set the state of boolean permissions. See https://notifications.spec.whatwg.org/ for how simple this can be.
  3. permissions.request() should not be available in workers I think.
@jyasskin
Copy link
Member

jyasskin commented Apr 1, 2016

I've done (1) in #66; the rest should wait for separate PRs.

@marcoscaceres
Copy link
Member

2 above is duplicate of #42 ... 1 was done in #66, and 3 doesn't apply as there is no .request().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants