Editorial fixes #100
Editorial fixes #100
Conversation
| might only expose the status to web pages when they try to use the API, | ||
| like the [[geolocation-API]] which fails if the permission was not | ||
| expose the status to web pages when they try to use the API, | ||
| like the [[Geolocation-API]] which fails if the permission was not |
There was a problem hiding this comment.
Bikeshed wants you to change the [[geolocation-API]] in #geolocation too.
There was a problem hiding this comment.
ah, boo. I thought it would support case insensitive look-up for bibref.
There was a problem hiding this comment.
Both of them match; it's Bikeshed saying that we should use a consistent spelling of a [[reference]] within a given spec.
|
There's a bunch of bikeshed errors here. Could you run bikeshed over the file and fix them? |
|
Will do! Sorry, still new to bs. |
|
trying to address BS fatal errors... getting strange ones like: |
| @@ -128,7 +123,7 @@ spec: webidl | |||
| or other sources this specification hasn't anticipated. | |||
| </dd> | |||
|
|
|||
| <dt><dfn export>Powerful feature</dfn></dt> | |||
| <dt><dfn export lt="powerful feature|feature">Powerful feature</dfn></dt> | |||
There was a problem hiding this comment.
Missed the possibility of local-lt here too: Probably we don't want this spec to define "feature" for the whole world? And then you can just remove the lt= since that's the content of the tag. Sorry for the bad suggestion earlier.
There was a problem hiding this comment.
Yes, <dfn export local-lt=feature>Powerful feature</dfn> is the ideal markup here.
https://api.csswg.org/bikeshed/?url=https://raw.githubusercontent.com/w3c/permissions/editorial_fixes/index.bs&output=both doesn't have any fatal errors, so that sounds like something in your bikeshed installation is broken. Repository is a known key, too. @tabatkins, any idea what it would be? |
|
Yeah, that'd be an old Bikeshed version. Go to your bikeshed folder and run |
marcoscaceres
force-pushed
the
editorial_fixes
branch
from
2e8a549 to
a84e053
Compare
|
@jyasskin, I explicitly marked "read-current-permission-state" as an algorithm. Is that ok? |
| same value, unless the UA receives <a>new information about the user's | ||
| intent</a>. | ||
| </p> | ||
| <p> |
There was a problem hiding this comment.
This is a different algorithm, defining the result of
"permission-name"'s extra permission data
There was a problem hiding this comment.
Sorry, I don't understand this comment :(
In case I don't hear back from you in the next few hours; I'm about to shift focus to another project for 2 weeks, so could I kindly request that you fix this for me in the editorial_fixes branch? I've already fixed the <var>s (there are ~30 vars that could maybe be converted also, but I guess we should do that in a new PR).
There was a problem hiding this comment.
Oh yeah, totally. I'd forgotten that this branch was in the main repo rather than a personal fork. I'll take it over.
|
Ok, everything except the details of 18f6961 looks good. |
marcoscaceres
force-pushed
the
editorial_fixes
branch
from
0289f00 to
e8345a8
Compare
|
rebased. |
|
(don't forget to merge me or there will be much bit rot 👍 ) |
jyasskin
force-pushed
the
editorial_fixes
branch
from
64cc49a to
709ae26
Compare
jyasskin
force-pushed
the
editorial_fixes
branch
from
709ae26 to
c9838be
Compare
No description provided.