Remove permissions.request() and permissions.revoke(). #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They've moved to incubations in https://github.com/jyasskin/permissions-request and https://github.com/jyasskin/permissions-revoke. This fixes w3c#46 and fixes w3c#83.
jan-ivar
suggested changes
Sep 22, 2017
| algorithm</a>. | ||
| </dd> | ||
| <dt> | ||
| A <dfn export>permission request algorithm</dfn> |
Member
There was a problem hiding this comment.
We still need this algorithm I think. It's referenced in mediacapture.
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Right! It's the former. I'll open an issue.
jan-ivar
approved these changes
Sep 22, 2017
martinthomson
approved these changes
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They've moved to incubations in https://github.com/jyasskin/permissions-request
and https://github.com/jyasskin/permissions-revoke, which I'll post to WICG once this goes in.
This fixes #46 and fixes #83.
Sorry it took me so long to get around to this. @martinthomson @jan-ivar, did I catch everything you don't want in this spec? @slightlyoff @raymeskhoury @mounirlamouri, did I include everything in the two incubations that you want to see there? (And that was written down at all; they're clearly missing a bunch of examples.)
Preview | Diff