-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for permissions that have an associated Feature Policy #163
Conversation
This adds support for denying access to permissions which are not allowed in the current context based on an associated Feature Policy. The Feature Name and Default Allowlist of a policy-controlled feature must still be declared in the owning spec. This also removes specific support for the media feature policy which is covered by the more general support.
@jyasskin ptal :) |
Btw, I'm still getting a bikeshed error with top-of-tree: Removing highlight='idl' from |
@raymeskhoury Any progress here? |
@jyasskin are you ok to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, with an update to match Feature Policy changes since you wrote it. I'm sorry for taking so long to look at this.
@raymeskhoury Can this be merged? |
@marcoscaceres: jyasskin is on leave. He's approved this and I've addressed his minor comments and rebased. Are you able to merge it? Thanks! |
Thanks @marcoscaceres! Oddly, https://w3c.github.io/permissions/ still isn't reflecting github tip. Does someone need to pull a crank or something? |
Hmm... Travis was supposed to run the deploy script. Might need to run it manually. |
manually pulled the crank https://w3c.github.io/permissions/ |
This adds support for denying access to permissions which are not
allowed in the current context based on an associated Feature Policy.
The Feature Name and Default Allowlist of a policy-controlled feature
must still be declared in the owning spec. This also removes specific
support for the media feature policy which is covered by the more
general support.
Preview | Diff