Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export permissions task source #407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

johannhof
Copy link
Member

@johannhof johannhof commented Dec 12, 2022

@annevk
Copy link
Member

annevk commented Dec 12, 2022

I'm not sure this makes sense. Shouldn't there be a single task queued that informs a document about a state (change) and that task is then used to do various things such as resolve promises or fire events?

As in, I would kinda expect the flow to be that other specifications ask something from Permissions with a set of completion steps and Permissions queues a task and runs those completion steps at the end of that task.

@marcoscaceres
Copy link
Member

Oops, approved before seeing Anne's comment. I was going to suggest something similar, in that it would be good if the permissions spec did more of the work.

@marcoscaceres marcoscaceres self-requested a review December 12, 2022 23:34
@marcoscaceres
Copy link
Member

I've also just spotted another incorrect usage of the task source in a different spec... it's being used where the "user interaction task source" should be used.

anssiko added a commit to anssiko/compute-pressure that referenced this pull request Dec 13, 2022
- Use user interaction task source instead of still evolving
  permissions task source.
  w3c/permissions#407

- Replace auto-generated issue 110 with a normal inline issue
kenchris pushed a commit to w3c/compute-pressure that referenced this pull request Dec 14, 2022
- Use user interaction task source instead of still evolving
  permissions task source.
  w3c/permissions#407

- Replace auto-generated issue 110 with a normal inline issue
@miketaylr
Copy link
Member

Looks like we're using it for userAgentData.getHighEntropyValues too: https://wicg.github.io/ua-client-hints/#dom-navigatorua-gethighentropyvalues. I'm guessing the intention was that the browser might reject based on implementation policy, i.e., something like "privacy budget", a user-setting or a "tracking protection" mode enabled. So it's kind of permission-y.

@annevk
Copy link
Member

annevk commented Feb 15, 2023

Note that using the same task source is really only about relative ordering for the tasks going into that task source.

And since there's only ever really a single task as the result of an in parallel algorithm in the case of permissions, relative ordering might not even matter? I'm not as much of an event loop expert as I'd like to be though, so it would be good if that could be verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants