Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to issue #319 in mDCv and cLLi chunk specifications in preparation for WD2 #324

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

palemieux
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ProgramMax ProgramMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Although, I am still not sure when to use / not use notes.
@svgeesus Would you mind taking a look?
(We can land this and then remove the note later, perhaps?)

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This use of note is fine, it is not a normative requirement is is providing extra information.

@svgeesus svgeesus merged commit 8f3687c into main Jul 11, 2023
@svgeesus svgeesus deleted the issues/link-to-issue-319 branch July 11, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants