Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Define preload cache and request matching algorithm #30

Closed
igrigorik opened this issue Aug 25, 2015 · 3 comments
Closed

Define preload cache and request matching algorithm #30

igrigorik opened this issue Aug 25, 2015 · 3 comments

Comments

@igrigorik
Copy link
Member

Relevant sections:

@igrigorik
Copy link
Member Author

From: https://groups.google.com/a/chromium.org/d/msg/blink-dev/_nu6HlbNQfo/OAzGqQa8BgAJ

if you preload something and another request gets there through a redirect, does it end up using the preloaded resource? (And is that response then changed to account for the possibly mixed content violating redirect?)

I think these will be answered once we resolve this bug, which is about defining the matching algorithm within Fetch. A really high-level overview of what I'm thinking:

  • we define a new response cache (name TBD, because we want it to be reused across preload, prefetch.. and probably even h2 server push'ed resources?)
  • preload inserts resources into this cache
  • fetch checks this cache prior to firing events at the SW/network/disk-cache

/cc @annevk @yoavweiss

@mnot
Copy link
Member

mnot commented Jun 3, 2016

That sounds sane-ish. H2 server push is already kept separate until it's actually referenced from content.

/cc @mcmanus

igrigorik added a commit that referenced this issue Nov 23, 2016
Preload response's are one of several responses that interact with the
(yet to be formally defined) response cache. As such, the logic for both
populating and querying said cache should live in Fetch.

- Updated issue text as a warning, with some context and pointer to the
  discussion in Fetch.
- Removed "match a preloaded response" definition: this should be
  handled transparently by Fetch, as one of the first steps in its main
  fetch algorithm.

Fetch issue where we should continue this discussion:
whatwg/fetch#354

Closes #30.
igrigorik added a commit that referenced this issue Nov 30, 2016
* response cache and matching lives in Fetch

Preload response's are one of several responses that interact with the
(yet to be formally defined) response cache. As such, the logic for both
populating and querying said cache should live in Fetch.

- Updated issue text as a warning, with some context and pointer to the
  discussion in Fetch.
- Removed "match a preloaded response" definition: this should be
  handled transparently by Fetch, as one of the first steps in its main
  fetch algorithm.

Fetch issue where we should continue this discussion:
whatwg/fetch#354

Closes #30.
@annevk
Copy link
Member

annevk commented Dec 7, 2016

I think it would be good to actually leave this open until it is properly defined.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants