Fix report developer homepage link. #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the the same object check for developer homepage text and link href.
davidlehn
requested review from
gkellogg,
dlongley and
yamdan
as code owners
dlongley
approved these changes
Nov 16, 2023
gkellogg
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the the same object check for developer homepage text and link href.
I've never written haml before, so this is a best guess at using a local var. The to_s was used above so I did the same. Please adjust as needed.
This is an issue for the Digital Bazaar rdf-canonize report which has a HTTPRange-14 related issue and uses the same developer id and homepage, resulting in an object for the homepage, and the JSON was getting encoded as a URL.
I'd also be nice to put parens around the homepage or something to make it clear there are two links. I failed to figure out how to do that and make it look good. Something like:
Ima Developer (https://example.com/)