Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-99: full stop should be commas #104

Merged
merged 2 commits into from
Oct 22, 2024
Merged

GH-99: full stop should be commas #104

merged 2 commits into from
Oct 22, 2024

Conversation

afs
Copy link
Contributor

@afs afs commented Oct 22, 2024 •
edited by pr-preview bot
Loading

This closes #99

Preview | Diff

@afs afs added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Oct 22, 2024
@afs afs requested a review from gkellogg October 22, 2024 09:31
TallTed
TallTed reviewed Oct 22, 2024
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
hartig
hartig approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@hartig hartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with Ted's edit.

@afs @TallTed
Update spec/index.html
a2861a7 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@afs afs merged commit 70887f8 into main Oct 22, 2024
2 checks passed
@afs afs deleted the iherman branch October 22, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

@gkellogg gkellogg gkellogg approved these changes

@domel domel domel approved these changes

@iherman iherman iherman approved these changes

@hartig hartig hartig approved these changes

Assignees
No one assigned
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two (very minor) editorial issues: full stop should be comma
6 participants
@afs @gkellogg @domel @iherman @hartig @TallTed