Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-100: Literal equality and language tags #105

Merged
merged 1 commit into from
Oct 24, 2024
Merged

GH-100: Literal equality and language tags #105

merged 1 commit into from
Oct 24, 2024

Conversation

afs
Copy link
Contributor

@afs afs commented Oct 22, 2024

This closes #100.

This suggestion turns the list into bullet points.

Notes:
It is written as "case sensitive" in i18n-glossary.
It is "ASCII case-insenitive" in i18n-glossary.


Preview | Diff

spec/index.html Outdated
Comment on lines 808 to 813
<ol>
<li>the two <a>lexical forms</a> compare equal</li>
<li>the two <a>datatype IRIs</a> compare equal</li>
<li>the two <a>language tags</a> (if any) compare equal</li>
<li>the two <a>base directions</a> (if any) compare equal</li>
</ol>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no reason the various comparisons need to be done in the order of this presentation, so an unordered list is more appropriate.

Suggested change
<ol>
<li>the two <a>lexical forms</a> compare equal</li>
<li>the two <a>datatype IRIs</a> compare equal</li>
<li>the two <a>language tags</a> (if any) compare equal</li>
<li>the two <a>base directions</a> (if any) compare equal</li>
</ol>
<ul>
<li>the two <a>lexical forms</a> compare equal</li>
<li>the two <a>datatype IRIs</a> compare equal</li>
<li>the two <a>language tags</a> (if any) compare equal</li>
<li>the two <a>base directions</a> (if any) compare equal</li>
</ul>

Copy link
Contributor Author

@afs afs Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change made directly because of the item below.

I actually originally drafted it with bullets and changed to numbers because list above this one is numbered, as are other lists. There's a mix (maybe they are that way because it helps in saying "point 2" etc).

Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also consider updating the following sentence:

A literal is a language-tagged string if the third element is present and the fourth element is not present. Lexical representations of language tags MAY be case normalized, (for example, by converting to lower case).

and instead say "(for example, by canonicalizing as defined by BCP47 §4.5)". We shouldn't be encouraging normalization to lower case.

@afs
Copy link
Contributor Author

afs commented Oct 22, 2024

We might also consider updating the following sentence:

Change made.

@TallTed
Copy link
Member

TallTed commented Oct 22, 2024

Looks like this ordered list is what you refer to... as it appears to be the only ordered list in the document previewed from here.

I suggest that also be changed to unordered (likewise the nested sub-list), as the order by which the items are evaluated doesn't appear to me to matter; they're all mutually exclusive.

@afs
Copy link
Contributor Author

afs commented Oct 24, 2024

I suggest that also be changed to unordered (likewise the nested sub-list), as the order by which the items are evaluated doesn't appear to me to matter; they're all mutually exclusive.

@TallTed would you like to put in a PR for that? Thanks.

This PR is in response to a specific comment #100. I find it easier to make progress if editorial PR's don't grow. It can become problematic with longer living and wider PRs.

@gkellogg gkellogg merged commit 209dde6 into main Oct 24, 2024
2 checks passed
@gkellogg gkellogg deleted the equality branch October 24, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Literal equality and language tags
4 participants