Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds RDF term equality definitions #161
base: main
Are you sure you want to change the base?
Adds RDF term equality definitions #161
Changes from 3 commits
358399e
1ec1807
96c4ef2
c8a7545
8a301f0
ca48f3f
6e621f0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could live with that, but I find it needlessly verbose and confusing. The point here is not to produce a new value that happens to be equal to the argument, the point is to return the argument itself...
I would slightly prefer to keep '=' here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, it would actually be a better idea to replace the
=
by "is" (e.g., "M(iri) is iri" instead of "M(iri) = iri").Notice, however, that this wording makes a difference for literals: Consider two literals, lit1 and lit2, which both have the same lexical form, both have
rdf:langString
as their datatype, and one of them has "EN" as its language tag whereas the other one has "en" instead. In this case, lit1 is not lit2, but they are equal according to literal term equality. So, if we say "M(lit) is lit" in this definition here, then M(lit1) cannot return lit2 but must return lit1; in contrast, if the definition says "M(lit) = lit" (and assuming=
means literal term equality), then M(lit1) may also return lit2 (as an alternative to returning lit1).I am not even sure which of these two cases we actually want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I like that.
You gave me a lot to think about with this puzzle :) My conclusion (which I will explain in more detail in the main conversation of this PR) is that this is not (or should not be) an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I have removed this one because the cross-references to these definitions are integrated directly into the definition above now.