Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update definitions for visibility and to remove duplicates #17

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Update definitions for visibility and to remove duplicates #17

merged 2 commits into from
Mar 31, 2023

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Mar 23, 2023 •
edited by pr-preview bot
Loading

to either not export, or to be references to equivalent terms in RDF Concepts.

Fixes #16. Also see w3c/rdf-star-wg#37.

Preview | Diff

@gkellogg gkellogg added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Mar 23, 2023
@pfps
Copy link
Contributor

pfps commented Mar 23, 2023

Looks good. I've put in a PR to reduce vocabulary, but this should go in first and I'll update my PR.

pfps
pfps approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine

@gkellogg gkellogg mentioned this pull request Mar 23, 2023
Closed
31 tasks
@domel domel self-requested a review March 23, 2023 22:32
@pfps pfps mentioned this pull request Mar 27, 2023
Merged
@gkellogg gkellogg mentioned this pull request Mar 29, 2023
Merged
@pfps pfps merged commit 9f41603 into main Mar 31, 2023
@pfps pfps deleted the exported-terms branch March 31, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfps pfps pfps approved these changes

@domel domel domel approved these changes

@doerthe doerthe Awaiting requested review from doerthe

@timothee-haudebourg timothee-haudebourg Awaiting requested review from timothee-haudebourg

Assignees
No one assigned
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updates to exported terms
3 participants
@gkellogg @pfps @domel