-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition: Use 'ill-typed' and 'value space' from RDF Concepts #75
Conversation
e6be729
to
0eadcbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Rebased to current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it seems that the title of the issue and the actual changes are inconsistent:
the changes only apply to "value space", and leave "ill-typed" untouched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, except that appears to only cover value space.
Already changed! There may be others - I only looked in the datatypes section. There are many changes needed throughout the document to make it current #78. |
RDF Concepts now has the target ill-typed definition. |
Thanks for catching that. I messed up the rebase and resolving the conflict. Fixed. I checked the Echidna report - no errors - but there are unrelated warnings (collected on #78) |
Please merge. |
RDF Concepts uses ill-typed and so might others docs.
ill-typed should be in RDF Concepts like other defns in the this section.
See w3c/rdf-concepts#153
Preview | Diff