Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition: Use 'ill-typed' and 'value space' from RDF Concepts #75

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

afs
Copy link
Contributor

@afs afs commented Jan 31, 2025

RDF Concepts uses ill-typed and so might others docs.
ill-typed should be in RDF Concepts like other defns in the this section.

See w3c/rdf-concepts#153


Preview | Diff

@afs afs force-pushed the dfn-ill-typed branch 2 times, most recently from e6be729 to 0eadcbe Compare January 31, 2025 15:23
@afs afs changed the title Definition: ill-typed in RDF Concepts Definition: Use 'ill-typed' and 'value space` from RDF Concepts Jan 31, 2025
@afs afs requested review from pchampin, doerthe and pfps January 31, 2025 15:24
@afs afs changed the title Definition: Use 'ill-typed' and 'value space` from RDF Concepts Definition: Use 'ill-typed' and 'value space' from RDF Concepts Jan 31, 2025
Copy link
Contributor

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@afs
Copy link
Contributor Author

afs commented Jan 31, 2025

Rebased to current main.

Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems that the title of the issue and the actual changes are inconsistent:
the changes only apply to "value space", and leave "ill-typed" untouched

Copy link
Contributor

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, except that appears to only cover value space.

@afs
Copy link
Contributor Author

afs commented Jan 31, 2025

LGTM, but it seems that the title of the issue and the actual changes are inconsistent: the changes only apply to "value space", and leave "ill-typed" untouched

Already changed!

There may be others - I only looked in the datatypes section.

There are many changes needed throughout the document to make it current #78.

@afs
Copy link
Contributor Author

afs commented Jan 31, 2025

RDF Concepts now has the target ill-typed definition.
This PR can be merged.

@afs
Copy link
Contributor Author

afs commented Jan 31, 2025

Fine, except that appears to only cover value space.

Thanks for catching that. I messed up the rebase and resolving the conflict.

Fixed.

I checked the Echidna report - no errors - but there are unrelated warnings (collected on #78)

@afs
Copy link
Contributor Author

afs commented Feb 6, 2025

Please merge.

@pfps pfps added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Feb 6, 2025
@pfps pfps merged commit e1e77ab into main Feb 6, 2025
2 checks passed
@pfps pfps deleted the dfn-ill-typed branch February 6, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants