Add some tests covering regex quantifiers and options

[Tpt]

Based on XPath spec: https://www.w3.org/TR/xpath-functions/#regex-syntax

Issue #46

[rubensworks]

@Tpt Is there a particular reason this was only added for sparql10 and not sparql11?

[Tpt]

@Tpt Is there a particular reason this was only added for sparql10 and not sparql11?

@rubensworks If I am not mistaken the sparql11 folder only contains tests for features added by SPARQL 1.1. For example BGP and basic operators (=, <, +...) tests are only in the sparql10 directory. Because REGEX was introduced in SPARQL 1.0 I added the tests there for consistency.

[rubensworks]

Oh, in that case I misunderstood how the tests are structured...

[jitsedesmet]

I noticed 2 more things when implementing the tests in Comunica.

First:
The result file regex-no-metacharacters-case-insensitive.srx is missing?

Second:

The following manifest entry sticks out

:regex-data-quantifier-optional a mf:QueryEvaluationTest ;
      mf:name    "REGEX with an ? quantifier" ;
      mf:action
          [ qt:query  <regex-quantifier-optional.rq> ;
            qt:data   <regex-data-quantifiers.ttl> ] ;
      mf:result  <regex-quantifier-optional.srx> .

The subject is :regex**-data-**quantifier-optional while it operates over the files regex-quantifier-optional. Is there a need for the mention of -data-?

Anyway, thank you for addressing my previous remarks :)

[Tpt]

The result file regex-no-metacharacters-case-insensitive.srx is missing?

Yes, out of laziness because it should return the same results as regex-no-metacharacters.srx

The subject is :regex**-data-**quantifier-optional while it operates over the files regex-quantifier-optional. Is there a need for the mention of -data-?

None, it is an artifact or an older naming I removed late in the MR writing. Fixed.

Anyway, thank you for addressing my previous remarks :)

With pleasure! Thank you for testing this MR.

[afs]

@Tpt -- Do you want to squash the commits down to one? Or I can do in the GH interface? Or leave it as 8 commits for "rebase and merge" (this repo normally uses "rebase and merge").

[Tpt]

@afs Done! Buf feel free to do it in GitHub interface the next times if you prefer.

[afs]

Oh, in that case I misunderstood how the tests are structured...

@rubensworks - I don't think we have a definite policy.

More tests is better. Structure can change.

My (mild) pref would be new test areas under sparql-current. In this case, there is already existing test area and splitting them across sparql-N seems less helpful.

It does mean we are not keeping the compliance tests for Sparql-VER exectly as used at the time as implementation reports but that could be quite a burden for not much value IMO. It's a tradeoff of more tests for sparql-current over a historical record of implementation reports.