Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use better BIDI examples. #78

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Use better BIDI examples. #78

merged 3 commits into from
Oct 28, 2024

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Oct 24, 2024 •
edited by pr-preview bot
Loading

Fixes #75.

Preview | Diff

@gkellogg gkellogg added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Oct 24, 2024
@gkellogg gkellogg requested review from afs and iherman October 24, 2024 22:40
iherman
iherman approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should flag this explicitly for the upcoming a11y review to see if this is all right. I am always messed up: should we see here what is displayed properly or what is stored in memory? I guess it is the former.

domel
domel approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@domel domel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite simple editions. Agree.

TallTed
TallTed suggested changes Oct 25, 2024
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@gkellogg @TallTed
Move comment on multi-line literal outside of the literal itself.
e0cd186 
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
TallTed
TallTed suggested changes Oct 28, 2024
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
@gkellogg gkellogg merged commit c91c04b into main Oct 28, 2024
2 checks passed
@gkellogg gkellogg deleted the directional-text-examples branch October 28, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed requested changes

@iherman iherman iherman approved these changes

@domel domel domel approved these changes

@afs afs afs approved these changes

Assignees
No one assigned
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More about directions
5 participants
@gkellogg @afs @domel @iherman @TallTed