Bump minimal supported version of Node.js from v14 to v18 #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by dependency on ReSpec (#1270). Note the dependency is only in tests meaning that Reffy should continue to run with Node.js v14 for now. That said, it does not seem a good idea to maintain two different minimal versions of Node, one for the source and one for tests. Plus there would be no way to specify that in `package.json`. A major version of Reffy will need to be released.
dontcallmedom
approved these changes
Apr 24, 2023
If Node.js 18 supports cache directives, we might also get rid of fetch-filecache-for-crawling entirely. Do you know if it does? I note that getting rid of node-fetch in fetch-filecache-for-crawling is a bit more involved than just replacing node-fetch with fetch. Response objects, readable streams, writable streams used in the code also need to be updated as the new objects don't follow the exact same API. |
tidoust
added a commit
that referenced
this pull request
Apr 24, 2023
Breaking changes: - Bump minimal supported version of Node.js from v14 to v18 (#1271) Required by dependency on ReSpec, although note this dependency is only for tests (`devDependencies` in `package.json`). The crawler itself should continue to run under previous versions of Node for now but this may not last! Dependencies bumped: - Bump respec from 32.8.0 to 34.0.1 (#1270). This triggers the need to bump the minimal supported version of Node.js. - Bump puppeteer from 19.9.1 to 19.10.1 (#1267) - Bump rollup from 3.20.4 to 3.20.7 (#1266) - Bump semver from 7.4.0 to 7.5.0 (#1264) Feature patched: - Events: Skip asides in "fire an event" phrasing (#1269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by dependency on ReSpec (#1270). Note the dependency is only in tests meaning that Reffy should continue to run with Node.js v14 for now. That said, it does not seem a good idea to maintain two different minimal versions of Node, one for the source and one for tests. Plus there would be no way to specify that in
package.json.A major version of Reffy will need to be released.