Links extraction: skip dfn panels #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Via #1584 (comment). Aside dfn panels only contain links that already appear somewhere else in the spec. These links were extracted and categorized as `autolinks` when they appeared in the final index of a Bikeshed spec, which essentially did not do anything because the links had already been extracted as `autolinks` in any case. The problem is that Respec also uses similar panels (but no `<aside>`), and Bikeshed sometimes outputs the panels at the end of the document, and not within the index itself as expected in the code. In these situations, the links were extracted a second time, as `rawlinks`. Not extracting the panels avoids duplication entirely.
dontcallmedom
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via #1584 (comment).
Aside dfn panels only contain links that already appear somewhere else in the spec.
These links were extracted and categorized as
autolinkswhen they appeared in the final index of a Bikeshed spec, which essentially did not do anything because the links had already been extracted asautolinksin any case.The problem is that Respec also uses similar panels (but no
<aside>), and Bikeshed sometimes outputs the panels at the end of the document, and not within the index itself as expected in the code. In these situations, the links were extracted a second time, asrawlinks. Not extracting the panels avoids duplication entirely.