Remove the Report and ReportBody interfaces #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Jun 11, 2025
github-actions bot
added a commit
that referenced
this pull request
Jun 11, 2025
SHA: 1e48c2e Reason: push, by yoavweiss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jun 11, 2025
SHA: 1e48c2e Reason: push, by yoavweiss Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Jun 12, 2025
TimvdLippe
added a commit
to TimvdLippe/webappsec-csp
that referenced
this pull request
Jun 18, 2025
Following the changes in w3c/reporting#284 all report bodies now need to be dictionaries, following the conclusion of w3c/reporting#216
mikewest
pushed a commit
to w3c/webappsec-csp
that referenced
this pull request
Jun 22, 2025
Following the changes in w3c/reporting#284 all report bodies now need to be dictionaries, following the conclusion of w3c/reporting#216
TimvdLippe
reviewed
Jul 4, 2025
| dictionary Report { | ||
| DOMString type; | ||
| DOMString url; | ||
| ReportBody? body; |
There was a problem hiding this comment.
FYI this does not appear to compile with WebIDL:
--- stderr
Traceback (most recent call last):
File "/home/tvanderlippe/Projects/servo/components/script_bindings/codegen/run.py", line 168, in <module>
main()
File "/home/tvanderlippe/Projects/servo/components/script_bindings/codegen/run.py", line 48, in main
parser_results = parser.finish()
^^^^^^^^^^^^^^^
File "/home/tvanderlippe/Projects/servo/third_party/WebIDL/WebIDL.py", line 9436, in finish
production.validate()
File "/home/tvanderlippe/Projects/servo/third_party/WebIDL/WebIDL.py", line 2402, in validate
raise WebIDLError(
WebIDL.WebIDLError: error: Dictionary Report has member with nullable dictionary type, /home/tvanderlippe/Projects/servo/components/script_bindings/codegen/../webidls/ReportingObserver.webidl line 13:14
ReportBody? body;
^
warning: build failed, waiting for other jobs to finish...
Shouldn't type and url be marked as required, and body is implicitly optional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the obsoleted #258
This change removes the web-exposed interfaces for
ReportandReportBody, as there's no use case for them.