Add diagram, change labels #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OR13
commented
May 21, 2023
•
OR13
commented
OR13
commented
May 21, 2023
| @@ -160,7 +129,7 @@ async function createVcExamples() { | |||
| vcProofExampleIndex++; | |||
| const verificationMethod = example.getAttribute('data-vc-vm'); | |||
| suite.verificationMethod = | |||
| verificationMethod || 'did:key:' + keyPair.publicKey; | |||
There was a problem hiding this comment.
Remove bias towards a particular did method.
BenjaminMoe
reviewed
May 23, 2023
| @@ -4,7 +4,11 @@ | |||
| <title>Verifiable Credentials ReSpec Test</title> | |||
| <meta http-equiv='Content-Type' content='text/html;charset=utf-8'/> | |||
| <script src='https://www.w3.org/Tools/respec/respec-w3c' class='remove'></script> | |||
| <script type="module"> | |||
| import mermaid from 'https://cdn.jsdelivr.net/npm/mermaid@10/dist/mermaid.esm.min.mjs'; | |||
|
related PR: w3c/vc-bitstring-status-list#67 |
davidlehn
reviewed
May 24, 2023
| @@ -79,6 +87,80 @@ <h1>Examples</h1> | |||
| } | |||
| } | |||
| </pre> | |||
| <section> | |||
There was a problem hiding this comment.
This is an example of the respec plugin. What is the graph for? Was the idea this would be autogenerated? It doesn't match the example data above.
There was a problem hiding this comment.
Why is this being added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.