-
Notifications
You must be signed in to change notification settings - Fork 49
[Spec] Correctly specify authenticatorSelection requirements #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(Still a draft as the actual links aren't fixed yet; testing that the build change actually fails the build) |
fde9362
to
2d6fa1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @stephenmcgruer,
It seems you removed some text we had previously added about residentKey and authenticatorAttachment. Was that intentional?
@rsolomakhin @ianbjacobs - |
@stephenmcgruer, |
These were previously incorrect specified as auth-time requirements, but they are actually registration time arguments. This was overlooked as the build action didn't fail on warnings by default. This commit also changes the action to fail in such cases.
2d6fa1a
to
9c9d0b7
Compare
@rsolomakhin @ianbjacobs - properly specified the limitations, please take a look. Rouslan, please double-check I've listed these correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct. Thank you!
SHA: ba809db Reason: push, by @stephenmcgruer Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
These were previously incorrect specified as auth-time requirements, but they
are actually registration time arguments. This was overlooked as the build
action didn't fail on warnings by default. This commit also changes the action
to fail in such cases.
Fixes #129
Preview | Diff